Webpack bundling duplicate React dependencies? about electron-react-boilerplate

[chentsulin]

Oh, because webpack target electron will break some module including socket.io in webpack-dev-server, and then break whole hot loading. Now it's hard to configure which modules we should push into externals, which should not.

Should ignore:

• electron built-in (ipc, remote...)
• node built-in (see webpack/node-libs-browser)
• node 3rd party which can't build with webpack (mysql, mongodb, and so on..)

Should not ignore:

• front-end node_modules (especially which have react in peerDependencies)

We will need to figure out a new webpack target for electron-renderer, or parser package.json peerDependencies field for easier configuration.

For now, you can work around it with:

var nodeModules = fs.readdirSync('node_modules').filter(function(x) {
    return x !== '.bin' && x !== 'react' && x !== 'react-router' && 'react-ui-tree';
});

see also #31

[chadobado]

Thanks a lot @chentsulin, very helpful and your workaround addressed my problem in the interim.

Looks like a minor typo in your snippet, updating here for anyone else that might find this:

  var nodeModules = fs.readdirSync('node_modules').filter(function(x) {
    return x !== '.bin' && x !== 'react' && x !== 'react-router' && x !== 'react-ui-tree';
  });

Thanks again