Socket.io warnings about electron-react-boilerplate

[chentsulin]

There are some problems with webpack-dev-server 1.8 and ws, I will update it to fix this.

[0x80]

👍

[chentsulin]

It seems that wepback-dev-server rely on a old verion ws v0.4.31 and it has some try catch code in BufferUtil.js to let it works for somehow.

try {
  module.exports = require('../build/Release/bufferutil');
} catch (e) { try {
  module.exports = require('../build/default/bufferutil');
} catch (e) { try {
  module.exports = require('./BufferUtil.fallback');
} catch (e) {
  console.error('bufferutil.node seems to not have been built. Run npm install.');
  throw e;
}}}

In my opinion, maybe it's not a issue, just a warning because this try catch flow usage.

[chentsulin]

I finally figure out this is a issue with webpack target: 'atom' and engine.io-client, and it breaks react-hot now.

See socketio/engine.io-client#376, webpack/webpack-dev-server#191

[0x80]

thanks for investigating!

[asfktz]

it is possible to disable react hot somehow until it fixed?

[chentsulin]

webpack --watch with npm start will works. But should refresh manually using Cmd + R.

[haustraliaer]

Hmmm I'd honestly rather have some warnings flash up than forego hot reloading... is this an option? Or do you think the issue will be resolved quite soon?

Or perhaps I can just use an older release of this boilerplate?

[chentsulin]

Hot reload should be fixed in 0.2.9.

But using target web maybe not be a good enough solution. Let's keep tracing issues between webpack and socket.io here.

[t1mmen]

@chentsulin, I overwrote my 0.2.8 make-webpack-config.js with the one from 0.2.9, but I'm getting the following error:

[19438:0817/122219:INFO:CONSOLE(744)] "Uncaught TypeError: Cannot read property '_currentElement' of null", source: webpack:///./~/react/lib/ReactCompositeComponent.js? (744)

Reverting back to the old make-webpack-config.js makes the error go away. Ideas?

[chentsulin]

@t1mmen

Uncaught TypeError: Cannot read property '_currentElement' of null

It's most likely a React issue or issue with react-hot-load. And also not everything in flux is hot-reloadable, so sometimes you should do a full refresh in your browser (or electron renderer).

[haustraliaer]

I got it working again by using:

npm run hot-dev-server
HOT=1 electron .

I had to remove NODE_ENV=development from the start command.

[chentsulin]

close via #35