Needless Response.clone() calls about wretch-middlewares

[hmnd]

@elbywan Thanks so much for taking the time to consider this! I think that's a perfect solution :)

[elbywan]

Hi @hmnd,

First sorry for not replying earlier, I'm a bit busy these days.

I would recommend to remove these response.clone() calls. Instead a disclaimer could be added in the documentation reminding the user that, if their until or onRetry function reads the response body, they should call response.clone() themselves.

I would take the opposite approach actually! Cloning the response will always work and is essential to allow the body to be read by multiple sources. But allowing the user to customize how to resolve the response (by checking the Content-Length header for instance and cloning only if appropriate) would be best in my opinion.

So I pushed a commit to add a resolver: Response => Response option to both middlewares that allows the user to do exactly that. (default is response => response.clone()