Coder Social home page Coder Social logo

Comments (10)

ruflin avatar ruflin commented on July 29, 2024 1

Looking forward to this tool. It would be nice to have 1 PR per package on the package-storage side.

from integrations.

exekias avatar exekias commented on July 29, 2024

At some point before packages are sent to the package-storage it would be interesting to bump versions and tag the package on this repo. This adds traceability and allows us to go back to a released package.

from integrations.

jonathan-buttner avatar jonathan-buttner commented on July 29, 2024

I think it would also be useful to have some hash of the contents of the package that is released. The hash could be checked in the PR to the package-storage repo. This would guarantee that the package that is tagged/versioned in this repo matches with the package that is released in the package-storage repo.

from integrations.

mtojek avatar mtojek commented on July 29, 2024

The current implementation (PR soon) compares changes in the version control system and if there are any updates that should be released. This model covers requirements of integrations, IMHO no need to introduce tags.
I'm happy to discuss the endpoint team use-case, let's first see how much does the tool satisfy your needs.

from integrations.

ph avatar ph commented on July 29, 2024

I think it would also be useful to have some hash of the contents of the package that is released. The hash could be checked in the PR to the package-storage repo. This would guarantee that the package that is tagged/versioned in this repo matches with the package that is released in the package-storage repo.

Would adding commit hash do the trick?

from integrations.

mtojek avatar mtojek commented on July 29, 2024

Next followups:

#46
#45

from integrations.

jonathan-buttner avatar jonathan-buttner commented on July 29, 2024

I think it would also be useful to have some hash of the contents of the package that is released. The hash could be checked in the PR to the package-storage repo. This would guarantee that the package that is tagged/versioned in this repo matches with the package that is released in the package-storage repo.

Would adding commit hash do the trick?

hmm I don't think a commit hash would work. The hash would ideally protect against an unlikely edge case where if say the copy command or however the PR is being created against the package storage repo failed halfway through the CI for the package storage repo could calculate some hash across the entire contents of the files in the PR and verify it against a file with a hash or something to make sure the contents of the PR lines up with what it's supposed to have. I think the commit hash is going to be different in the PR.

from integrations.

mtojek avatar mtojek commented on July 29, 2024

@jonathan-buttner

Once the PR #59 is merged, you can try to adopt the tool and see if you can release the endpoint. I'm happy to adjust the CLI to meet your expectations.

from integrations.

jonathan-buttner avatar jonathan-buttner commented on July 29, 2024

Thanks @mtojek we're currently using https://github.com/github/hub to open the pull request against package-storage. I'll take a look at the CLI tool.

from integrations.

mtojek avatar mtojek commented on July 29, 2024

Resolving

from integrations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.