0.4.8 transport.perform_request with curb body is no longer parsed JSON about elasticsearch-ruby

[karmi]

Seems to be specific to the Curb based transport... Will look into it.

[karmi]

The culprit is obviously 80c48dd

[mikebaldry]

That would be a good guess... curl response from the call to GET /_aliases does return as application/json so should be ok.

should the code be looking for Content-Type, not content-type in the headers hash?

[karmi]

should the code be looking for Content-Type, not content-type in the headers hash?

Good catch! Faraday "normalizes" the header like this, but obviously the Curb transport doesn't go through that...

[karmi]

This seems to be the problem:

client = ::Curl::Easy.new
=> #<Curl::Easy>

client.url = 'http://localhost:9200'
=> "http://localhost:9200"

client.http(:get)
=> true

client.header_str
=> "HTTP/1.1 200 OK\r\nContent-Type: application/json; charset=UTF-8\r\nContent-Length: 311\r\n\r\n"

client.headers
=> {}

[karmi]

Related: taf2/curb#184

[mikebaldry]

it looks like #headers is for setting headers on the request, not getting them from the response

[karmi]

Yes, but in any case seems like there's no version of headers parsed as a Hash in Curb yet.

Let's add the check for client.header_str =~ /\/json/ in https://github.com/elasticsearch/elasticsearch-ruby/blob/master/elasticsearch-transport/lib/elasticsearch/transport/transport/http/curb.rb#L31.

[karmi]

Closed in ecfe780