Problems with kaminari about elasticsearch-rails

[karmi]

That's quite weird, see the integration test at https://github.com/elasticsearch/elasticsearch-rails/blob/master/elasticsearch-model/test/integration/active_record_pagination_test.rb#L42

Are you loading Kaminari before the elasticsearch-model gem or configuring it?

[lfv89]

Hi Karmi, thanks for your response.

Yes, actually I'm both loading kaminari before the elasticsearch-model gem and also configuring it as you said in a related issue (sorry, forget the issue number). I'm gonna take a look at this integration test in a few hours than I reply here. And before I forget, I'm not using Activerecord, I'm using Mongoid!

[lfv89]

@karmi I just found the error. In a given context my search definition had a size: {}. So, the method limit_value from elasticsearch-model/lib/elasticsearch/model/response/pagination.rb was returning an empty hash, which broke the kaminari calculations. I thought of sending a PR to ensure that limit_value method will always return a number, but then I thought that the error was only my fault, so I changed my mind. What do you think?

[karmi]

Yeah, I think think people should just pass a number to size, I wouldn't hand-hold them :)

[benben]

btw this is also working for me with the patch from #42

[lfv89]

Good to know @benben. It was my mistake, I'm closing this issue!