Comments (7)
+1
the changed_attributes should filtered as like as_indexed_json cause maybe not all fields are public and used for indexing.
from elasticsearch-rails.
If we did want to make this work beyond trivial cases perhaps ES::Model should be asking the instance for updates rather than taking them out of changed attributes. There could always be a default implementation that just returned the changed attributes.
On the otherhand perhaps the pragmatic thing is to just write your own update_document if you have that need.
from elasticsearch-rails.
Please see #5 .
from elasticsearch-rails.
D'oh - I'm a dummy. Given that the conclusion has been reached that the library shouldn't be trying to do anything smart in this case, perhaps the documentation should reflect this?
from elasticsearch-rails.
+1 to document it's behavior in README. I had custom callbacks, and it would not update the serialized json field. The solution was to just use es.index_document on the models that have serialized fields versus update_document. Its a bit of a performance killer most likely, but it works and is only updated on a cron job every 20 mins.
from elasticsearch-rails.
@fcheung I'm still thinking whether we can somehow intercept the changes better, but I don't think so. It would be nice to check whether the model itself (and not the proxy) implements the as_indexed_method
...
from elasticsearch-rails.
@fcheung Actually, the simple case was quite simple to solve, unless I'm missing something very obvious -- please check the linked commit.
from elasticsearch-rails.
Related Issues (20)
- NPE happens on short prefix query on a field with index_prefixes
- Indexes are not refreshing, even with refresh_interval being set
- Disable automatic callbacks in rspec
- Not getting any records from elasticsearch HOT 1
- FYI gem version 6.1.1 was pushed without any changes HOT 1
- elasticsearch-model 7.2.1 introduces circular dependency with ruby 2.7 and rubygems 3.2.5 HOT 1
- specify an alias near the index_name in an AR model HOT 1
- Illegal argument "type" sent in all requests upgrading to 8.x HOT 1
- Not able to update single record too please help me to here HOT 1
- How to import into two clusters
- Mapping Two Ruby on Rails Models with Different Attribute Names to a Shared Elasticsearch Index using 'elasticsearch-rails'
- update_document not selective enough
- Backward compatibility for older Elasticsearch version HOT 1
- Faraday::ConnectionFailed (end of file reached) HOT 1
- Elasticsearch - Unexpected Character Error (Minus Sign) HOT 1
- Unexpected behavior when searching from a scope
- Feature Suggestion - Get Indexed Document for Instance
- Deprecation warning in Rails 7.1 (support Rails 7.2) HOT 2
- ElasticSearch::Model does not register a subclass HOT 3
- rake elasticsearch:import:model - ArgumentError: unknown keyword: :type (ArgumentError)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elasticsearch-rails.