Skip Java package install if java already installed about ansible-elasticsearch

[gingerwizard]

Hi @geoffroya i've made some changes which should ensure the java version is only updated if the an update_java param is passed. I'll make further improvements to perform a repo update in this scenario also. This should avoid unnecessary checks.

I have concerns the above approach may cause issues where a non-compatible version of java is installed. What about a flag install_java, with a default value of true. If false, we skip the java install.

@dliappis thoughts?

[dliappis]

@gingerwizard agreed. I assume @geoffroya is referring to a situation where java has been installed without a package manager, hence the checking for the executable in the shell PATH.

Your recommendation for an install_java flag defaulting to True sounds reasonable to me.
I thought for a second if we could make this slightly more intelligent, e.g. check if there is already a java package installed and then set install_java=false (which would be overridable), but the lack of a list option for the package module would make all of this cumbersome.

[gingerwizard]

@geoffroya we will add a flag for the next release. Feel free to make the pull request or i'll just add when i have a moment. Thanks for the feedback either way!

[geoffroya]

Hi @gingerwizard

I've created a pull request to add the flag, as suggested by @dliappis

[gingerwizard]

@geoffroya resolved through #107

[vesharma]

If you install java with alternative it will not work. Even I tried with command with that I can install java but unable to determine whether java was exist or not so looking for else if or kind of filter in playbook

[vesharma]

---

• name: check
  hosts: all
  become: true
  gather_facts: false
  tasks:

  • name: print a message
    command: java -version 2>&1 | grep version | awk '{print $3}' | sed 's/"//g'
    register: version
    ignore_errors: True

  • name: print java version
    debug:
    msg: " {{ version i}} "
    when: " version.rc == 0 "

  • name: install java version
    command: "{{ item }}"
    when: "version.rc !=0"
    with_items:

    • alternatives --install /usr/sbin/java java /ql/java/jdk1.8.0_152/bin/java 1000