Cannot build fresh copy of Manifold. about manifold

[elalish]

Have you tried a clean build? I had to do that recently because of CMake changes.

[briansturgill]

@elalish Yes, I removed the old tree enirely and then did a fresh git.

[elalish]

Hmm, it looks like it's having trouble pulling down GLM for some reason. You can always install GLM in your system so it doesn't need to. Still, I wonder if we're somehow pointing to a bad version?

[james-bern]

I think I'm experiencing the same problem on Windows.

  fatal: reference is not a tree: b06b775c1c80af51a1183c0e167f9de3b2351a79
  CMake Error at glm-subbuild/glm-populate-prefix/tmp/glm-populate-gitclone.cmake:49 (message):
    Failed to checkout tag: 'b06b775c1c80af51a1183c0e167f9de3b2351a79'

Notes:

• https://stackoverflow.com/questions/57879408/impossible-to-checkout-a-git-commit
• g-truc/glm@673a963

[briansturgill]

Installing libglm-dev didn't help.

[pca006132]

@briansturgill can you show the cmake log after installing libglm-dev? pkg-config should be able to find glm and it should not require running FetchContent.

I will try to figure the checkout problem as well.

[pca006132]

ok found the problem, I should not use GIT_SHALLOW.
Try this:

diff --git a/manifoldDeps.cmake b/manifoldDeps.cmake
index eb0f7f0..3866a19 100644
--- a/manifoldDeps.cmake
+++ b/manifoldDeps.cmake
@@ -21,7 +21,6 @@ else()
     FetchContent_Declare(Clipper2
         GIT_REPOSITORY https://github.com/AngusJohnson/Clipper2.git
         GIT_TAG Clipper2_1.3.0
-        GIT_SHALLOW TRUE
         GIT_PROGRESS TRUE
         SOURCE_SUBDIR CPP
     )
@@ -38,7 +37,6 @@ endif()
 FetchContent_Declare(glm
     GIT_REPOSITORY https://github.com/g-truc/glm.git
     GIT_TAG b06b775c1c80af51a1183c0e167f9de3b2351a79
-    GIT_SHALLOW TRUE
     GIT_PROGRESS TRUE
     FIND_PACKAGE_ARGS NAMES glm
 )
@@ -61,7 +59,6 @@ if(MANIFOLD_PAR STREQUAL "TBB" AND NOT TBB_FOUND)
     FetchContent_Declare(TBB
         GIT_REPOSITORY https://github.com/oneapi-src/oneTBB.git
         GIT_TAG        v2021.11.0
-        GIT_SHALLOW    TRUE
         GIT_PROGRESS   TRUE
     )
     FetchContent_MakeAvailable(TBB)