About getFeedItemLink method about feedbundle

[eko]

Hi,

Yes, good idea. I will think of it in the next days because I'm currently on holidays for the rest of the week.

Thank you for your analyze and don't hesitate to send me a pull request if you have a particular idea on this topic.

[topwebstudio]

I am looking at a similar bundle - https://github.com/prestaconcept/PrestaSitemapBundle
It's done externally when looping through results, maybe this is the way to go here too?

public function boot()
    {
        $router = $this->container->get('router');
        $event  = $this->container->get('event_dispatcher');

        //listen presta_sitemap.populate event
        $event->addListener(
                SitemapPopulateEvent::onSitemapPopulate, 
                function(SitemapPopulateEvent $event) use ($router){
                    //get absolute homepage url
                    $url = $router->generate('homepage', array(), true);
                    //add homepage url to the urlset named default
                    $event->getGenerator()->addUrl(new UrlConcrete(
                            $url, 
                            new \DateTime(), 
                            UrlConcrete::CHANGEFREQ_HOURLY, 
                            1), 'default');
                });
    }

[eko]

Thank you, I think I will implement something similar but I need to let people able to use a custom URL so if people want to use a custom one, they were be able to, otherwise they will just need to put the route name in the configuration of their feed.

I'll let you know about this!

[topwebstudio]

Okay thanks!

[eko]

Hi, thanks to @RobMasters contribution you can now use the Symfony router component in the bundle to generate your items links.

Thank you for your suggestion and have fun with it :)

[topwebstudio]

Looks great I'll try it! Thanks!