Coder Social home page Coder Social logo

Incorrect inline-style about amber HOT 3 CLOSED

eknkc avatar eknkc commented on May 29, 2024
Incorrect inline-style

from amber.

Comments (3)

adamzy avatar adamzy commented on May 29, 2024

It seems that the ZgotmplZ is returned by go html/template to indicate the content is unsafe.
But why is color:black; background:write unsafe in style?

from amber.

pyramids avatar pyramids commented on May 29, 2024

I don't know. However:

This exposes the fact that amber's handling of parts of the amber template is at odds with package html/template's security approach, treating templates as trusted and data as untrusted. Amber injects parts of the amber templates as data into templates of type html/template, subjecting what should be trusted (Amber) templates to treatment intended to protect from malicious injections. This is presumably responsible for many issues, including this one.

from amber.

kcuzner avatar kcuzner commented on May 29, 2024

Just for the record, I do have a workaround. I'm sure that others already have found & used this workaround, but I figure I could just post it here for posterity until it gets fixed (if it needs to be fixed...this seems to work pretty well for me):

Since amber compiles to html/template, something of type template.CSS can be returned and used in the style attribute. Here is an example from my latest project:

import (
    "fmt"
    "html/template"
)

type tagData struct {
    Tag   string
    Size  float64
}

func (t tagData) Style() template.CSS {
    return template.CSS(fmt.Sprintf("font-size: %.2fem;", t.Size))
}

This object is passed in to my template as Tag:

...
a[href="/posts/tag/" + Tag.Tag"][style=Tag.Style] #{Tag.Tag}
...

And is rendered as (for data {"MyTag",0.7}:

<a href="/posts/tag/MyTag" style="font-size: 0.70em;">MyTag</a>

from amber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.