Coder Social home page Coder Social logo

Comments (5)

eight04 avatar eight04 commented on June 8, 2024

It's more reasonable that only parsing error will set model value to undefined.

from angular-datetime.

eight04 avatar eight04 commented on June 8, 2024

@bkmediagroup-josh

from angular-datetime.

bkmediagroup-josh avatar bkmediagroup-josh commented on June 8, 2024

I returned undefined because un-setting the model value on failed validations seems to be a convention in angular. If there is a better place for that validation to live, I am all for moving it.

from angular-datetime.

eight04 avatar eight04 commented on June 8, 2024

Starting from 1.3.0, there is a $validate() function in ngModelController, you can manually call that function to run validation. If the validation fails, angular will set the model value to undefined.

Here is how angular observe the min/max changes in input[number]:
https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1372-L1379
Angular will call $validate() each time the min/max value updated:
http://plnkr.co/edit/xAz9Lj50SszZCLJJjq17?p=preview
But we don't have this function in 1.2.x and validation only happens if view value is changed:
http://plnkr.co/edit/WLSzJkp9HvpRwls9DvvH?p=preview

Maybe we shouldn't observe min/max in 1.2.x.

from angular-datetime.

eight04 avatar eight04 commented on June 8, 2024

Fixed in 2.0.0.

Keep the original behavior, which will set model value to undefined if min/max is not valid. Also add support for $validators in Angular 1.3.x:
https://github.com/eight04/angular-datetime/blob/master/src/directive.js#L320

from angular-datetime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.