Comments (5)
It's more reasonable that only parsing error will set model value to undefined.
from angular-datetime.
from angular-datetime.
I returned undefined because un-setting the model value on failed validations seems to be a convention in angular. If there is a better place for that validation to live, I am all for moving it.
from angular-datetime.
Starting from 1.3.0, there is a $validate()
function in ngModelController
, you can manually call that function to run validation. If the validation fails, angular will set the model value to undefined.
Here is how angular observe the min/max changes in input[number]
:
https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1372-L1379
Angular will call $validate()
each time the min/max value updated:
http://plnkr.co/edit/xAz9Lj50SszZCLJJjq17?p=preview
But we don't have this function in 1.2.x and validation only happens if view value is changed:
http://plnkr.co/edit/WLSzJkp9HvpRwls9DvvH?p=preview
Maybe we shouldn't observe min/max in 1.2.x.
from angular-datetime.
Fixed in 2.0.0.
Keep the original behavior, which will set model value to undefined if min/max is not valid. Also add support for $validators
in Angular 1.3.x:
https://github.com/eight04/angular-datetime/blob/master/src/directive.js#L320
from angular-datetime.
Related Issues (20)
- Module 'custom-input' is not available HOT 7
- Placeholder HOT 2
- TypeError: date.getTime is not a function HOT 2
- Cursor jumps to end of input field on up/down keys HOT 12
- Compatibility with Angular UI Bootstrap DatePicker Popup HOT 2
- Error parsing (w3c formatted) datetimes having timezone different than the datetime parser one HOT 7
- Object.values HOT 2
- Placeholder isn't actually a placeholder and no way to turn it off HOT 3
- Bug: set day HOT 8
- how can I reset placeholder HOT 1
- Any Way To Use Timezone Strings (UTC, EST)? HOT 1
- Unused property Element.handler HOT 1
- strictdi error on version 5.1.3 HOT 1
- Add bower support. HOT 1
- Incorrect Year when using shortDate format HOT 1
- it is no going through steps, it is just stay in days HOT 3
- IE 11 not supported HOT 4
- Create a new version for angular 2+ HOT 5
- Can't initialize control with anything but current date HOT 6
- Timestamp HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-datetime.