Comments (5)
from torchstain.
I have made a PR which adds support for this for all backends: #30
from torchstain.
Problem with original Reinhard method is that you should have chosen the target image properly, as the processed image's statistics is very much dependent on the target image's statistics. That's why, we proposed Modified Reinhard in which source image's background luminance is preserved as it is. Previously many researchers shown in their paper that, Reinhard did not work, because they choose target image very dark. However, our proposed method alleviated this limitation, because our proposed method transfers background color and contrast statistics from target to source, however, we preserved the background luminance.
Before, you choose a target image, please consult with us.
from torchstain.
@shaanroy Thank you for the clarification. The modifications you proposed to the Reinhard algorithm are surely relevant and technically sound, hence, why I wanted to add support for it in the first place. I'm a huge fan of the generic nature of Reinhard and actively use it in my own research, so it is great to see improvements being made :] Thanks for that!
Regarding my comment above:
It does not seem that the modified reinhard is that much different from the original implementation. Hence, API-wise, it might be a good idea to add a
method
argument to Reinhard, to choose which implementation of Reinhard to use.
It was not my intention to degrade your work, with this comment. I was only asking whether the modifications I made to my reinhard implementation were correct, as I was surprised how simple implementing the proposed solution was. I'm sorry again if it came out differently than I intended.
As my implementation will soon be merged with the master branch (already merged with the development branch), it would be great if you could review the implementation to verify that it seems correct:
https://github.com/EIDOSLAB/torchstain/blob/development/torchstain/numpy/normalizers/reinhard.py#L51
from torchstain.
Fixed in 17c2d28.
from torchstain.
Related Issues (20)
- Support for Vahadane normalization HOT 2
- Multiple backends support HOT 7
- Update runtimes HOT 2
- Conda compatibility?
- Update About and tags HOT 1
- Fix tf implementaton of percentile HOT 1
- Releases not showing anymore?
- Support for Reinhard HOT 2
- Support for Jax HOT 24
- Support for torch.linalg.lstsq HOT 3
- Crash when calling MacenkoNormalizer.fit with tensorflow backend HOT 12
- Whole Slide Images HOT 7
- Add stain augmentation alternative HOT 1
- Documentations? HOT 1
- No GPU acceleration in torch backend
- Typo in rgb2lab transform HOT 2
- IndexError: kthvalue(): Expected reduction dim 0 to have non-zero size. HOT 3
- Add unit tests? HOT 13
- Add Zenodo DOI HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torchstain.