Comments (3)
According to the team that knows the device I'm connecting to, the handshake does work without it. It's just that when data comes through the socket, it isn't properly categorized on the other end (the desired callback never gets called).
It seems to me that differentiating protocols based on the connection URL (like SWSS does) is pretty much equivalent to differentiating based on the Sec-Websocket-Protocol field, our problem is that we have two parties, each using the other method.
If I end up adding the ability to use Sec-Websocket-Protocol, I'll put it in a pull request so you can decide if you want to integrate it. If we end up fixing it on the server side I'll comment back here in case somebody else runs across this. Either way, it's not your bug, so I'll go ahead and close this.
Also, I just wanted to say that I think you're great--definitely one of my favorite people on github. If all the software that we pay for was as high quality and well supported as the software that you make available for free, we'd be much better off. Thank you.
from simple-websocket-server.
Thank you for the excellent writeup. If I follow you correctly, it seems that Sec-Websocket-Protocol
is missing in the client handshake (and probably in the server handshake response as well). But this field is optional (see https://tools.ietf.org/html/rfc6455#section-4.2.1), and handshakes should work without it. If not, it might be an error in the server's implementation.
I'm open to making changes here, though, I am not entirely sure of the advantages of the subprotocols that can be listed in Sec-Websocket-Protocol
.
from simple-websocket-server.
Also, you can play around with the client handshake here: https://github.com/eidheim/Simple-WebSocket-Server/blob/master/client_ws.hpp#L366
from simple-websocket-server.
Related Issues (20)
- [suggest] Send/Broadcast and Text/BinaryMode HOT 1
- Standalone Asio not found - but asio.hpp is present HOT 4
- re again WssClient::start causes on_error HOT 10
- When I use Google Chrome it happend a error. HOT 3
- exception thrown in server start (boost related) HOT 4
- Connection Timeout HOT 2
- Create example on how to stream data to a client HOT 1
- Unable to compile against standalone asio HOT 1
- How to stop the server? HOT 3
- Installed but ws_examples throws an error HOT 1
- fatal error C1083: Cannot open include file : 'pthread.h': No such file or directory HOT 1
- Messages split among frames aren't reasembled HOT 25
- Openssl wants void* instead of char* in 0x1000115fL HOT 1
- how to initiate send message from client HOT 3
- Client request error: End of file
- Access violation exeption HOT 3
- gdiplus
- Can't use wss client HOT 5
- Integration with Simple-Web-Server HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-websocket-server.