Inconsistent behavior regarding cycles about error-serializer

[ehmicky]

Hi @papb!

Thanks a lot for the kind word :)

This is intentional. The reason is: errorSerializer.serialize() first converts error to a plain object before passing it to safe-json-value (under the hood). However, error static properties are not converted to plain objects. So safe-json-value cannot figure out that error (now converted to a plain object) is the same as error.cycle (not a plain object). But it can detect that error.cycle is the same as error.cycle.cycle, which ends up converting error.cycle to an empty object.

That being said, I agree this is rather surprising when you compare both projects. Replacing circular values with empty objects is probably fine, but undefined would be better. The good news is: I am planning to make error-serializer deep by default, which should take care of the above problem. I'll update this issue once this is done.

Thanks for pointing this out!

[ehmicky]

This should be fixed in 3.0.0. Cycles are now removed instead of being set to an empty object.

[papb]

@ehmicky This project's readme is still the same as in my original post here though, I guess it has to be fixed then?

[ehmicky]

Thanks for pointing this out @papb, I just fixed it.

@all-contributors Please add @papb for bug report and doc.

[allcontributors]

@ehmicky

I've put up a pull request to add @papb! 🎉