Directions $copyrights issue about ivorygooglemapbundle

[egeloen]

@dupuchba Google has removed the property?

[dupuchba]

No it doesn't look like there change anything but when I var_dump my directionRoute object, there is no $copyright prop...

[egeloen]

Strange... According to https://developers.google.com/maps/documentation/directions/#Routes the route should contain a copyrights. As the behavior seems not always same, IMO, we should make a check when the route is rebuild. If there is no copyrights, fallback on null. What's your opinion?

[dupuchba]

That's what seems to happen with us (websites work well but sometimes no copyrights... which crash the page...) In my opinon if there is no copyrights, then set it to '' or null. You do it? or i do it?

[egeloen]

I'm currently fixing it :)

[dupuchba]

ok cool :) 🎱

[egeloen]

The issue should be fixed by egeloen/ivory-google-map@b5bcd661bf

Can you confirm? :)

[dupuchba]

Yep, good! I hope you this won't happen again for other properties :)... Thx for your reactivity!

By the way if you have 2min, I also raised an issue in egeloen/ivory-google-map#23 . I already saw your work un-merged in google-places for your pull-request egeloen/ivory-google-map#18 .

Good work, are you going to merge it? Anyway I think it should be possible to add services without any php implementations in the few cases (but real :) ) where you have to use the map with other services and where you can't load twice the google map api!