Coder Social home page Coder Social logo

Comments (5)

seshrs avatar seshrs commented on June 2, 2024

Very weird bug! My guess is that this is happening only now because GitHub Pages deployments have moved to GitHub Actions. But I'm going to need to debug this further.

from primer-spec.

noah-weingarden avatar noah-weingarden commented on June 2, 2024

Unfortunately, the sidebar tutorial links are currently broken as described in this issue for the production build of project 4.

from primer-spec.

seshrs avatar seshrs commented on June 2, 2024

😱 oof, thanks for raising! I'm looking into this now.

from primer-spec.

seshrs avatar seshrs commented on June 2, 2024

I quickly suspected that the issue was related to the baseurl property, but it took me several embarrassing commits to properly fix seshrs/build-primer-spec-action 😅

If you're curious, this is the fix: https://github.com/seshrs/build-primer-spec-action/blob/e04cb027b517ccf0aa6ea99397d73375169cf6c0/action.yml#L16-L33

And if you're curious what baseurl does in Jekyll, here's a TLDR:

https://eecs485staff.github.io/p4-mapreduce/heapq.html
                                           ^^^^^^^^^^^ path
                              ^^^^^^^^^^^^^ baseurl (was being set to 'pages' by default for some reason)
^^^^^^^^^^^^ url ^^^^^^^^^^^^^

(Further reading: https://mademistakes.com/mastering-jekyll/site-url-baseurl/)


I took the liberty of re-running the deploy job (attempt 2) for the P4 website. The links in the Sidebar now work!

from primer-spec.

noah-weingarden avatar noah-weingarden commented on June 2, 2024

Huh, that isn't very well-documented in GitHub Pages/Jekyll, is it? Thanks Sesh!

from primer-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.