Comments (5)
Very weird bug! My guess is that this is happening only now because GitHub Pages deployments have moved to GitHub Actions. But I'm going to need to debug this further.
from primer-spec.
Unfortunately, the sidebar tutorial links are currently broken as described in this issue for the production build of project 4.
from primer-spec.
from primer-spec.
I quickly suspected that the issue was related to the baseurl
property, but it took me several embarrassing commits to properly fix seshrs/build-primer-spec-action
If you're curious, this is the fix: https://github.com/seshrs/build-primer-spec-action/blob/e04cb027b517ccf0aa6ea99397d73375169cf6c0/action.yml#L16-L33
And if you're curious what baseurl
does in Jekyll, here's a TLDR:
https://eecs485staff.github.io/p4-mapreduce/heapq.html
^^^^^^^^^^^ path
^^^^^^^^^^^^^ baseurl (was being set to 'pages' by default for some reason)
^^^^^^^^^^^^ url ^^^^^^^^^^^^^
(Further reading: https://mademistakes.com/mastering-jekyll/site-url-baseurl/)
I took the liberty of re-running the deploy job (attempt 2) for the P4 website. The links in the Sidebar now work!
from primer-spec.
Huh, that isn't very well-documented in GitHub Pages/Jekyll, is it? Thanks Sesh!
from primer-spec.
Related Issues (20)
- `script/server` requires specific shells HOT 7
- Bump header level styles in sidebar if needed HOT 1
- Primer Spec v2: Require deploy via GitHub Actions? HOT 1
- Task Lists: Use 'pointer' cursor on hover
- Multi color highlighting HOT 5
- Spooky icons even when Spooky theme not chosen HOT 2
- Data-highlight inside callout HOT 2
- Dark mode code blocks flash when settings is closed HOT 1
- Markdown tables are not rendered HOT 2
- Copy button in enhanced codeblock omits whitespace HOT 3
- Enhanced code block copy-paste trailing newline
- [PR Previews] PDFs do not generate with correct styles the first time.
- [Code blocks] Overflow gets clipped in print previews
- [Enhanced code blocks] No-line-numbers variant doesn't occupy full width
- [Enhanced code blocks] Code block in EECS 280 P1 doesn't highlight lines HOT 1
- [Enhanced Code Blocks] Line-by-line copying excludes empty lines
- Local render Liquid Exception HOT 6
- Copying an enhanced codeblock duplicates newlines HOT 1
- Sidebar has wrong URLs in PR previews HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primer-spec.