Comments (6)
OK, this is due to https://github.com/eea/eea.facetednavigation/blob/master/eea/facetednavigation/tests/test_doctests.py#L25
It should be
got = re.sub("u'(.*?)'", "'\\1'", got)
and not
got = re.sub("u'(.*?)'", "'\\1'", want)
I will propose a separated PR...
from eea.facetednavigation.
@gbastien Sounds good.
I would still keep the purge at criteria level for backward compatibility. Thus:
- If you have
<criteria purge="True">
then the old behavior will apply (allcriterions
are erased before import) - Otherwise each
<criterion purge="True">
will replace existing ones.
from eea.facetednavigation.
yes sure still useful at the <criteria>
level, just need to define it at the <criterion>
level.
Actually we apply a little XML file just redefining one single <criterion>
and leaving others untouched.
I will propose a PR soon.
Thank you for follow up!
Gauthier
from eea.facetednavigation.
Hi @avoinea
working on this issue and adding tests to exportimport.txt
, I could not make doctest fail, even when writing wrong things!
Looking at the doctest setup, it is due to the checker=Py23DocChecker()
defined in test_doctests.py
while configuring the exportimport.txt
doctest.
You may test, if you remove the checker=Py23DocChecker()
and run bin/test --test exportimport.txt
, you have failing tests.
So I think that may be the case with other doctests as well...
So I do not know why this is failing and how to fix this...
Gauthier
from eea.facetednavigation.
Hi @avoinea
so under py2, you may write anything wrong in a doctest, it does not fail.
But maybe this will fail in your jenkins while running test on py3?
from eea.facetednavigation.
Fixed with #205
from eea.facetednavigation.
Related Issues (20)
- Allow multiple sorts indexes HOT 2
- Count breaks when using a text widget and collective.solr
- Filter Path widget items by navigation_settings.displayed_types HOT 1
- autocomplete widget with select2 broken in Plone 5.2
- Link to last page of batch navigation broken with batch having many pages
- CSS / JS expression can lead to traceback in plone.resourceregistries viewlet HOT 2
- doc tests are never failing HOT 10
- Make it possible to use same index for several criteria and do this work together HOT 3
- <label> needed on <select> for Section 508 compliance HOT 1
- Issue with autocomplete widget values
- Alphabetic widget is no longer countable
- "Results per page" widget only works when setting the default per page to 10. Otherwise paginations will not appear on the page view. HOT 2
- JS error when editing widgets on Plone 6 (r.getClientRects is not a function) HOT 1
- Plone toolbar Display menu may not be shown even if you have several faceted layouts
- Display rich text value on a collection ? HOT 5
- Update for Plone 6 HOT 6
- widgets not displaying the title of an item correctly HOT 6
- "Try it with docker" fails HOT 3
- "Hide items with zero results" option is not working anymore
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eea.facetednavigation.