Mosquitto container changes ownership of directory on disk about dapr-workshop

[EdwinVW]

As long as it also still works on a Windows machine, I'm fine with that.
Just to be clear: what's exactly the issue with the folder's ownership changing?

[mthmulders]

The ownership of the folder changes to 1883, which is most likely not the user id of the person doing the workshop. So they have a folder in their home directory that they cannot write to anymore - the only way to change that is to sudo chown -R ...... it. It's not an irreversible problem, it's just not that clean :-). And people might be surprised (like I was) or even upset that following the workshop brings up this situation.

[mthmulders]

⚠️ This is potentially disastrous! ⚠️

The other day, I incidentally ran the Windows command on a Linux machine, and I almost destroyed my setup.

The Windows command is docker run -d -p 1883:1883 -p 9001:9001 -v $pwd/:/mosquitto/config/ --name dtc-mosquitto eclipse-mosquitto - as $pwd is usually an empty string on Linux, it will map the root directory of the machine as /mosquitto/config/ in the container.

The container then changes ownership of /mosquitto/config/ to 1883:1883. On Linux, it will take a while to do this, but it will eventually render the system unusable, as all files are owned by a non-existing user.

@EdwinVW, is there another way to get the current working directory on Windows? On Linux, we can do pwd or $(pwd). There are probably some differences that I'm not aware of, but they roughly do the same...

[EdwinVW]

I'll look into whether there's another way on Windows.

[EdwinVW]

We could also add instructions on how to bake the config file into a Docker container image (using COPY) and use that for the workshop.

Would that not fix all issues (also the chmod stuff)??

[mthmulders]

That's exactly what my line of thought was...:

Would you be accepting a PR that addresses this, e.g. by copying over the configuration files to a temporary directory and then mounting that one into the Mosquitto container?

So yes, sounds like a brilliant plan to me :-)

[EdwinVW]

Yes, that was your suggestions but that's not what I mean.

I mean not mounting any folder when starting the container at all, but actually creating our own Mosquitto Docker image (based on the current one). We can than copy the config into the right folder inside the image. We than start the Mosquitto container from our own image. I'm already working on a Docker file for that.

[mthmulders]

Apologies for not reading carefully enough. But yeah, copying the config into the container rather than mounting it would also work fine.

[EdwinVW]

I have a working solution now. I will do a PR in which I update the way Mosquitto is used, and also update the instructions for .NET and Java so they comply with the updated approach.

[EdwinVW]

Fix is in PR #31.

@mthmulders Could you please review.

[EdwinVW]

I just executed assignment 6 for .NET and everything worked as expected.