Comments (3)
Hi @none2003,
Thanks for pointing this out! The notebook should include an additional check that 20 bars have been completed:
def rank(ctxs: dict[str, ExecContext]):
if tuple(ctxs.values())[0].bars <= 20:
return
scores = {
symbol: ctx.indicator('roc_20')[-1]
for symbol, ctx in ctxs.items()
}
sorted_scores = sorted(
scores.items(),
key=lambda score: score[1],
reverse=True
)
threshold = pyb.param('rank_threshold')
top_scores = sorted_scores[:threshold]
top_symbols = [score[0] for score in top_scores]
pyb.param('top_symbols', top_symbols)
def rotate(ctx: ExecContext):
if ctx.bars <= 20:
return
if ctx.long_pos():
if ctx.symbol not in pyb.param('top_symbols'):
ctx.sell_all_shares()
else:
target_size = pyb.param('target_size')
ctx.buy_shares = ctx.calc_target_shares(target_size)
ctx.score = ctx.indicator('roc_20')[-1]
What's happening is that caching does not maintain the order of the rows of the original DataFrame. During the initial 20 bars of the backtest, the 20 day ROC score will be NaN, so the order of the scores will depend on the order that the symbols appear in the DataFrame. That ordering becomes non-deterministic once the cached data is read.
The issue is with the notebook code, not the caching mechanism. I have updated the notebook with the fix:
https://www.pybroker.com/en/latest/notebooks/10.%20Rotational%20Trading.html
Let me know if you need anything else.
from pybroker.
PyBroker does maintain the ordering of the dates, so the time sequence will be correct. However, the order in which the rows appear for different symbols on the same date does not have a guaranteed ordering.
from pybroker.
Hi @none2003,
Thanks for pointing this out! The notebook should include an additional check that 20 bars have been completed:
def rank(ctxs: dict[str, ExecContext]): if tuple(ctxs.values())[0].bars <= 20: return scores = { symbol: ctx.indicator('roc_20')[-1] for symbol, ctx in ctxs.items() } sorted_scores = sorted( scores.items(), key=lambda score: score[1], reverse=True ) threshold = pyb.param('rank_threshold') top_scores = sorted_scores[:threshold] top_symbols = [score[0] for score in top_scores] pyb.param('top_symbols', top_symbols)
def rotate(ctx: ExecContext): if ctx.bars <= 20: return if ctx.long_pos(): if ctx.symbol not in pyb.param('top_symbols'): ctx.sell_all_shares() else: target_size = pyb.param('target_size') ctx.buy_shares = ctx.calc_target_shares(target_size) ctx.score = ctx.indicator('roc_20')[-1]
What's happening is that caching does not maintain the order of the rows of the original DataFrame. During the initial 20 bars of the backtest, the 20 day ROC score will be NaN, so the order of the scores will depend on the order that the symbols appear in the DataFrame. That ordering becomes non-deterministic once the cached data is read.
The issue is with the notebook code, not the caching mechanism. I have updated the notebook with the fix: https://www.pybroker.com/en/latest/notebooks/10.%20Rotational%20Trading.html
Let me know if you need anything else.
Thank you for your quick action!
I'm a little confuse about "caching does not maintain the order of the rows of the original DataFrame", so how pybroker make sure the time sequence when get data from cache? Is data get resorted when retrieve from cache when using?
from pybroker.
Related Issues (20)
- Multi-timeframe? HOT 2
- Indicator might be wrong when applying filter on backtesting data HOT 2
- Add MAE (Maximum Adverse Excursion) and MFE (Maximum Favorable Excursion) metrics. HOT 1
- Add regular defined contribution to portfolio HOT 1
- Add Ruff for Python linter and code formatter HOT 3
- Real-time question HOT 1
- The feature names should match those that were passed during fit HOT 6
- [Feature] Add support for Schwab
- 设置了ctx.score的值后,买入的具体原则是怎样的,这个ctx.score具体作用和影响是什么呢 HOT 1
- How to set a different ctx.sell_fill_price HOT 1
- Error: Fill price 0 for prices below 0.005$ (like many cryptocurrencies) HOT 3
- fees and account amount HOT 5
- __init__() got an unexpected keyword argument 'adjust' HOT 1
- Data caching issue HOT 4
- 有考虑接入okx biance的数据么 HOT 1
- Add config option to save stop values in TestResult HOT 1
- caching data bug in month or week frequence HOT 2
- AKShare got an unexpected keyword argument 'timeframe' HOT 3
- Rotational Trading not working when using start_of_month HOT 1
- [Question] symbol for indicator but not for trading HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybroker.