Comments (7)
I have created two PRs (#42 and #45) which should address this issue -- more
specifically, a tox test matrix built on the changes in #43 also succeeds for
Django 3.0.
Merging both #42 and #45 would make django-private-storage work
with Django 3 (AFAICT, at least the unit tests succeed), but at the
price of losing compatibility with Python 2.7.
I leave it up to the maintainers of this fine project to make the decision, but
in my humble opinion, supporting Django 3.0 would be preferable to supporting
Python 2.7 past the upcoming EOL.
from django-private-storage.
Thanks for your work!
Django 3.0 support is fixed in 2.2.2!
I've used your PR's as inspiration, but implemented it in a python2 compatible way so I could do a minor version bump instead of major release that drops compatibility (see f017650)
from django-private-storage.
Hi @vdboor ! Thank you for maintaining this project so far. I would like to use django-private-storage
with Django 3. Is it possible to validate the #42 and #45 soon ? Thank you 😸
from django-private-storage.
EDIT: The fork is going away in a couple days because the original repository now works with Django 3. Do NOT use this any more!
I forked @wiegandm's repo and merged the two PRs in there. If you want to play around with it (on your computer, not in production), you can use this entry in your requirements.txt
to install the patched version of django-private-storage
:
# This fixes an incompatibility with Django 3. Once the following PRs are merged, go back to the original django-private-storage package:
# 42 https://github.com/edoburu/django-private-storage/pull/42
# 45 and https://github.com/edoburu/django-private-storage/pull/45
git+https://github.com/winsmith/django-private-storage.git@master#egg=django-private-storage
Don't forget to back to the original repo once the maintainers found a way to ensure Django 3 compatibility. My fork won't be updated, and it's more of a stopgap solution for now. Also I wouldn't run this in production without a LOOOT of testing.
from django-private-storage.
Thanks a lot!
from django-private-storage.
Thank you
from django-private-storage.
Woohoo thanks so much!
from django-private-storage.
Related Issues (20)
- Google cloud storage and others
- DjangoServer does not respect Content-Type
- How to retrieve files by object id? HOT 3
- adjust to django-storages 1.10.1 HOT 3
- Serve files that weren't uploaded via Django Admin/API HOT 2
- files not being served/downloaded properly HOT 3
- RemovedInDjango40Warning for ugettext_lazy import HOT 1
- Howto avoid traceback in case of PermissionDenied in custom can_access_file? HOT 1
- UnicodeEncodeError when uploading non-ascii filenames HOT 3
- UUID as a primary key HOT 1
- Reverse for 'send_private_file' not found. Django 4.0 HOT 1
- SuspiciousFileOperation
- How create custom permission ?
- Custom private storages with nginx
- FileNotFoundError if the file associated with a model instance has been removed, and delete() is called on a ModelForm for that instance. HOT 1
- django 4.1 compatibility HOT 5
- Make it to html
- https is not served when using drf.
- Checks fail in Actions CI Testing
- An error occurred (403)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-private-storage.