Incompatibility with Django 3 about django-private-storage

[wiegandm]

I have created two PRs (#42 and #45) which should address this issue -- more
specifically, a tox test matrix built on the changes in #43 also succeeds for
Django 3.0.

Merging both #42 and #45 would make django-private-storage work
with Django 3 (AFAICT, at least the unit tests succeed), but at the
price of losing compatibility with Python 2.7.

I leave it up to the maintainers of this fine project to make the decision, but
in my humble opinion, supporting Django 3.0 would be preferable to supporting
Python 2.7 past the upcoming EOL.

[vdboor]

Thanks for your work!
Django 3.0 support is fixed in 2.2.2!

I've used your PR's as inspiration, but implemented it in a python2 compatible way so I could do a minor version bump instead of major release that drops compatibility (see f017650)

[neoCheck]

Hi @vdboor ! Thank you for maintaining this project so far. I would like to use django-private-storage with Django 3. Is it possible to validate the #42 and #45 soon ? Thank you 😸

[winsmith]

EDIT: The fork is going away in a couple days because the original repository now works with Django 3. Do NOT use this any more!

---

I forked @wiegandm's repo and merged the two PRs in there. If you want to play around with it (on your computer, not in production), you can use this entry in your requirements.txt to install the patched version of django-private-storage:

# This fixes an incompatibility with Django 3. Once the following PRs are merged, go back to the original django-private-storage package:
# 42 https://github.com/edoburu/django-private-storage/pull/42
# 45 and https://github.com/edoburu/django-private-storage/pull/45
git+https://github.com/winsmith/django-private-storage.git@master#egg=django-private-storage

Don't forget to back to the original repo once the maintainers found a way to ensure Django 3 compatibility. My fork won't be updated, and it's more of a stopgap solution for now. Also I wouldn't run this in production without a LOOOT of testing.

[wiegandm]

Thanks a lot!

[neoCheck]

Thank you

[winsmith]

Woohoo thanks so much!