Comments (14)
@MichaelKetting you might have noticed we merged a change to the specification explicitly disallow inline comments in the ini-parsing for EditorConfig. The next step will be aligining the EditorConfig parsers out there.
from specification.
Oh, right. I think that @florianb and I agreed that that particular rule wasn’t ideal, but we should probably have had the spec align with current implementations.
from specification.
Thank you very much for pinging me @MichaelKetting – you are absolutely right. What a pity.
@editorconfig/board-member Regarding this case and the thoughts we already put into a rework/creation of a ini grammar are there any objections to try remove inline comments in general?
I think introducing a viable escape mechanism would be a second option, though I think it would be more ergonomic to try to abandon inline comments at first.
Given there are no objections i'd try to push this forward including taking on Jed's work at the spec PR #29 . Thank you all very much.
from specification.
I meant to create this in https://github.com/editorconfig/specification. Can someone with permissions for both repositories use the Transfer Issue feature to move it?
from specification.
This seems like an oversight in the spec language (#12) that none of us happened to catch. @jedmao Do you recall anything regarding this?
from specification.
This wasn't an oversight. I thought it was a bit of a silly rule, but preserved it because of the existing tests that were mentioned above.
from specification.
@jedmao I don't think the language preserves the existing tests though. The current test says that if you have a colon after a value, it should be taken as part of the value. The language says that it shouldn't be taken as part of the value, at least for now.
from specification.
Yeah - i can't recall the full discussion, yet,
But we skipped support for inline comments for the revision of ini parsing and specification entirely because of it's ambiguity.
I agree we should change the spec.
from specification.
@florianb This ticket's been in limbo since March 2021. Do you have an update about the status of spec? Not being able to use semi-colons in string values of editor.config prevents some powerful usage scenarios from moving forward.
Much appriciated, Michael
from specification.
@florianb No objection from my side.
from specification.
@florianb #29 is only a clarification PR -- it doesn't require any changes related to the tests. I think it's safe to approve and merge if you agree with the changes in #29 .
from specification.
Yeah thanks @xuhdev – i thought waiting some days for response may have gained more feedback. 😅
from specification.
Following up --- it looks like #29 and editorconfig/editorconfig-vote#6 are contradictory on the surface. To help out dotnet/roslyn#44596 , could we define it one way or the other?
Edit Would it make sense to open an issue in editorconfig/editorconfig
asking for votes about whether people expect ;
and #
in a value to start a comment or not?
from specification.
Following up --- it looks like #29 and editorconfig/editorconfig-vote#6 are contradictory on the surface. To help out dotnet/roslyn#44596 , could we define it one way or the other?
@cxw42 The reason those two are contradicted is that the poll happened later than #29, and we decide to go the way as the poll has decided.
Edit Would it make sense to open an issue in
editorconfig/editorconfig
asking for votes about whether people expect;
and#
in a value to start a comment or not?
That would be a useful survey, but I don't think it's worth the effort to massively change the behavior (which is not really a particularly groundbreaking feature any way)
from specification.
Related Issues (20)
- Versioning with SemVer HOT 2
- Introduce AST + validation errors HOT 21
- Clarification on insert_final_newline behavior for empty files HOT 3
- Clarify the behavior of leading slash in section title HOT 2
- Clarify behavior of trim_trailing_whitespace HOT 6
- max_line_length is not specified HOT 15
- Readthedocs link mentioned in README.md not available HOT 4
- [Title]
- Tell IDE to ignore files HOT 3
- Odd grammatical syntax at supported-properties/root HOT 1
- Use editorconfig.org subdomain HOT 3
- How to have a multiline value HOT 2
- Clarify 'key containing whitespace' case HOT 8
- Table of Content HOT 6
- version tags? HOT 1
- Clarify glob matching HOT 7
- Clarify that spelling_language strings must be exactly two or five characters HOT 2
- Enhancement: Light comment style preference HOT 2
- Clarify behavior of formatting (non-"root") properties at top level HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from specification.