Comments (4)
Thanks for reporting! Would you please post instructions for reproducing the issue? Please make sure to include the specific commit at which you are testing. Much appreciated!
from editorconfig-core-c.
I am testing against master branch by invoking ec_glob(pattern, string)
with the pattern and the test strings from above.
from editorconfig-core-c.
I think this is a bug, as there's really no meaning *
in brackets. We really tried to mimic gitignore patterns in the beginning, and my experiment shows that gitignore would see *
as a literal inside brackets. Also checked out PCRE, same behavior.
I think this is also what the spec means, but we didn't write it clearly out.
from editorconfig-core-c.
Yes, I agree. There is another thing the spec does not clearly write out: slashes have precedence over anything else.
Meaning that a slash will "destroy" the bracket pattern.
Example: [ab/cd]
will not be translated as "one of a, b, /, c, or d" but instead it will be the literal sequence [ab/cd]
.
See also issue 499 in the main repo.
and you might also be interested in how I solved this.
However, since this looks very intentional, I think it's desired behavior - just not documented. So when fixing this bug, you might need to be careful not to change this behavior.
from editorconfig-core-c.
Related Issues (20)
- Bug: 0 is not considered a valid number for {num1..num2} HOT 2
- Option to use POSIX regex instead of PCRE HOT 6
- Brace pairing check in ec_glob.c incorrect? HOT 8
- Unchecked malloc return value
- Header files define reserved identifiers
- Usage of atoi() invokes undefined behaviour on integer overflow
- .editorconfig files with syntax errors can cause property lookup to fail, even if the file is in a directory beneath the "root" config HOT 2
- Clarify dependencies
- Glob: Handling of `?` HOT 7
- Chocolatey package is out of date
- Segfault while reading .editorconfig generated by JetBrains IDE HOT 9
- `editorconfig_parse()` leaks memory when no `.editorconfig` files are found or there are no values HOT 1
- 0.12.5: BUILD_STATICALLY_LINKED_EXE=OFF and static library is build and installed HOT 3
- Unexpected behavior on trailing slash HOT 1
- flatpak-builder: 'submodule' is not a git command HOT 1
- Missing MIT license text for CMake_Modules/FindPCRE2.cmake HOT 1
- Path to using a system copy of inih? HOT 2
- Not passing -vsver to subsequent calls of build.ps1
- Path splitting algorithm isn't UNC-aware
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from editorconfig-core-c.