Comments (5)
@magwas Are compiler warnings enough or do we need Unused import, Unused local variable, etc... (What currently Eclipse crying for)
For the second one, I guess we need CheckStyle.
from pdengine.
Either the CI build should fail or Sonar should block the merge. Even turning compiler warnings to errors in pom.xml is enough to consider this task to be done. The below is just additional details to see the big picture.
Be aware that I am working on code duplication detection right now, and as a side effect, PMD warnngs are also brought to Sonar.
I do not focus on this though, and have no idea whether PMD, CheckStyle, or any other tool is best suited for static code analysis. And it cannot hurt if we check with multiple tools.
from pdengine.
szirbucz
from pdengine.
And yes, everything Eclipse is showing as a warning should lead toblocking the merge.
from pdengine.
@magwas For static analysis I vote for PMD. On my last project we used both CheckStyle and PMD, because they are good for different goals.
CheckStyle checks the coding conventions, like indentation, spaces around brackets, naming conventions, length of line, etc...
PMD does real static analysis and discovers code smells, code duplication and possible bugs.
from pdengine.
Related Issues (20)
- the beat matrix contains the beats HOT 6
- beat matrix diagonal HOT 3
- beat matrix loosers HOT 2
- beat matrix winner's looses HOT 2
- beat matrix winner's wins HOT 2
- beat matrix ties HOT 7
- rank candidates HOT 1
- transitive closure HOT 4
- fix obtain ballot specidfication
- implement Matrix as a type
- fine tune PMD rules
- Add pmd to the eclipse in the docker image HOT 1
- Zombies are not shown in sonar's pull request analysis
- prefer gson over org.json
- finetune code duplication rules
- have a vote parameter on whether ties are allowed in cast vote
- make pmd not to cry for missing override on setUp
- use compareBeats instead of re-implementing its functionality. HOT 2
- spring eclipse feature does not install from Dockerfile HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pdengine.