Coder Social home page Coder Social logo

Comments (17)

angel1st avatar angel1st commented on June 22, 2024 2

Any idea how to move it forward? It was reported two months ago and basically, nobody gives an attention...

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024 1

guys - anyone able to at least elaborate on the issue? It's been almost three months since I reported it and so far nobody gives any valuable feedback...

from toast-phonegap-plugin.

442623641 avatar 442623641 commented on June 22, 2024 1

it work for me:
Toast.java, find
private static final boolean IS_AT_LEAST_PIE = Build.VERSION.SDK_INT >= 28;
replace with
private static final boolean IS_AT_LEAST_PIE = Build.VERSION.SDK_INT >= 26;

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024 1

2.7.1 is now compatible with any Android version, but it may have implications for how long the Toast is shown. It is what it is.

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024 1

Thanks, mate.
I see your point now and I do agree it is better to have a toast working on all Android versions.
Anyway, as long as this issue specifically addresses a duration malfunctioning, let's keep it open and hope at some point it will be fixed one way or another.

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024

Any chances to receive some feedback on the above issue?

from toast-phonegap-plugin.

lolaswift avatar lolaswift commented on June 22, 2024

Same issue. Only on android.

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024

@EddyVerbruggen - any chances to see this issue updated soon?

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024

Not by me, perhaps someone else.

from toast-phonegap-plugin.

442623641 avatar 442623641 commented on June 22, 2024

any chances to see this issue updated soon?

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024

@EddyVerbruggen - actually it does not fix the issue described above - at least not on the OS and the device reported by me. Hence I think the issue shouldn't been closed.

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024

I’d be happy to merge a PR to fix your issue, but I want to be transparent that there’s no fix to be expected by me.

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024

I must say I am a bit confused here - I have reported a bug for Android 8.0, confirmed by others as well. It has not been fixed, yet, the issue has been closed.
I believe at least if the issue cannot be fixed, in the plugin description it has to be clearly stated the fact that it does not support duration option for specific OS versions.
Why I should fill in a PR, while we have a bug, it is not clear to me as well.

I stand by my words - the issue should not been closed, since it has not been actually fixed.

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024

Happy to reopen, I’m just giving you a heads up I will not be fixing this any time soon, so you don’t have false expectations.

IMO it’s better to have a working Toast on all Android versions (fix in 2.7.1) than supporting a duration on all versions (it does work on some, but I don’t know which exactly).

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024

Thank you.

Btw, I noticed 2.7.1 ignores even the 'short' and 'long' duration settings (always 'long'). 2.7.2 fixes that.

from toast-phonegap-plugin.

angel1st avatar angel1st commented on June 22, 2024

Thanks, Eddy. Just to get this one straight - the user can set ether short or long duration and it will be respected; however, they cannot set duration via the toast.show method, correct?

from toast-phonegap-plugin.

EddyVerbruggen avatar EddyVerbruggen commented on June 22, 2024

I've tested these 3 (from the readme):

<button onclick="window.plugins.toast.showShortTop('Hello there!', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast showShortTop</button>
<button onclick="window.plugins.toast.showLongBottom('Hello there!', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast showLongBottom</button>
<button onclick="window.plugins.toast.show('Hello there!', 'long', 'center', function(a){console.log('toast success: ' + a)}, function(b){alert('toast error: ' + b)})">Toast show long center</button>

And all of those respect the short/long setting.

from toast-phonegap-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.