Discarding Draft or Sending Mail sometimes crashes app or sometimes just wont close mail view about nativescript-email

[EddyVerbruggen]

Is this iOS or Android?

[firescript]

This is on iOS, its really quite random though. Like right now my device is plugged in and i'm running on livesync and i'm not seeing either of these issues happen.

[EddyVerbruggen]

I've seen this happen on the simulator only, not on a device yet. Which iOS version is this (and which device)?

[firescript]

I am running 9.3 and its a 6s

[EddyVerbruggen]

I have a strong suspicion this line should be in a broader scope. That MFMailComposeViewController may be garbage collected when the composer is open (and your app is in the background). I just remembered a similar issue I've seen in a Cordova plugin.

[EddyVerbruggen]

Another cause could be the animated hiding of the compose and your app perhaps performing a transition at the same time (or showing a dialog).

[firescript]

Okay so the second scenario i'm not doing in my app, i'm letting your plugin return to the same view it was initiated from. When i built it for messenger plugin, this is where i allocated:

https://github.com/firescript/nativescript-messenger/blob/master/index.ios.js#L53

[EddyVerbruggen]

Interesting line of code
🤔🤔🤔🤔🤔

[firescript]

Yeah that addition was from @ivanbuhov pretty sure I was having weird closing issues before. Thats when we added that

[EddyVerbruggen]

can you add that locally to this plugin and keep an eye on it perhaps?

[firescript]

The initial part needs to be wrapped in a NSObject.extend to create the delegate, it started getting a little over my head when @ivanbuhov took over lol, I can try and play around with it though!

[EddyVerbruggen]

Let me know if you can pull it off, otherwise I'll take a look later this week. Thanks!

[ivanbuhov]

The idea behind this line is to keep the delegate instance alive. Since the messageComposeDelegate is weak it will not retain the delegate instance and after the JS wrapper is collected, the native instance will be deallocated, too. Explicitly retaining and releasing the delegate prevents its preliminary deallocation.

[grasshoppermouse]

I'm having similar problems as well. After sending an email, sometimes the app crashes. Other times the app returns to the view it was initiated from, but the screen is frozen. No errors in the console (and this is not run: console.log("Email composer closed");). Sometimes it returns from sending an email without errors.

[EddyVerbruggen]

@grasshoppermouse Thanks for reminding me of this issue - totally slipped my radar. Just released 1.3.4 which should fix this.