Coder Social home page Coder Social logo

Comments (4)

eddiesigner avatar eddiesigner commented on May 14, 2024 1

@maxart2007 That would work just for rectangles but not for other kind of shapes like circles, triangles and so on.

The best way to do it is checking for a common property shared by all this kind of instances. All of them use the MSShapePathLayer protocol so now I check for the edited property which is shared by all of them.

from sketch-map-generator.

maxart2007 avatar maxart2007 commented on May 14, 2024

After editing common.js (line 26) and replacing if statement
if ([layer class] != MSShapeGroup) {
with
if (([layer class] != MSRectangleShape)) {
everything just worked.

Sorry, don't have time to make a pull request at the moment :)

from sketch-map-generator.

eddiesigner avatar eddiesigner commented on May 14, 2024

@CharlieMouton Thanks for the heads up! Now it works just fine 👍

You was right, they made some internal changes related to the shapes but now the plugin supports both kind of approaches.

Please update the plugin to the latest version (2.0.4).

from sketch-map-generator.

maxart2007 avatar maxart2007 commented on May 14, 2024

Yes, I realize. Thanks for the quick update!

from sketch-map-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.