Comments (4)
@maxart2007 That would work just for rectangles but not for other kind of shapes like circles, triangles and so on.
The best way to do it is checking for a common property shared by all this kind of instances. All of them use the MSShapePathLayer
protocol so now I check for the edited
property which is shared by all of them.
from sketch-map-generator.
After editing common.js (line 26) and replacing if statement
if ([layer class] != MSShapeGroup) {
with
if (([layer class] != MSRectangleShape)) {
everything just worked.
Sorry, don't have time to make a pull request at the moment :)
from sketch-map-generator.
@CharlieMouton Thanks for the heads up! Now it works just fine 👍
You was right, they made some internal changes related to the shapes but now the plugin supports both kind of approaches.
Please update the plugin to the latest version (2.0.4).
from sketch-map-generator.
Yes, I realize. Thanks for the quick update!
from sketch-map-generator.
Related Issues (20)
- Reply to eddiesigner for map plugin HOT 1
- Shape Layer Must Be Vertical HOT 4
- Disabled Address Input HOT 1
- After connecting Mapbox account, custom styles are not displayed HOT 10
- Dynamic or half-decimal zoom levels HOT 3
- Cannot Preview Map in Sketch 59.1 HOT 5
- Can't generate map & preview it HOT 4
- feature proposal: re-create previous map HOT 3
- Preview works, but shape stays empty HOT 10
- ios Catalina HOT 2
- Is it possible to produce maps bigger in size? HOT 2
- Mapbox doesn't work with Sketch 52.6 HOT 4
- Do I need to restrict Google Maps Api Key when using Map Generator in Sketch? HOT 2
- [Feedback] Google Map Configuration Update (2020 June) HOT 2
- Where's the Map Generator.sketchplugin file?? HOT 1
- 谷歌地图请求被拒绝 HOT 2
- Licensing Question HOT 1
- Mapbox shortcut HOT 2
- crashed on Macbook Prp M1 HOT 2
- Support for Mapbox › Studio › custom styled map
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sketch-map-generator.