Coder Social home page Coder Social logo

Comments (19)

sital002 avatar sital002 commented on July 17, 2024 2

I am unable login because of missing "client_id"

screenshot of error

image

You need to add the environement variable for Github Oath to work. here is the link on how to setup your environement variable https://www.biodrop.io/docs/environments/environment-variables

from biodrop.

eddiejaoude avatar eddiejaoude commented on July 17, 2024 1

I have assigned to you @sohail-313

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

from biodrop.

github-actions avatar github-actions commented on July 17, 2024

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

from biodrop.

amandamartin-dev avatar amandamartin-dev commented on July 17, 2024

hi @sital002 can you confirm if this happens on production and on a mobile device? I have tested on my device and cannot replicate. (Android pixel running chrome)

ℹī¸ amandamartin-dev has some opened assigned issues: 🔧View assigned issues

from biodrop.

sital002 avatar sital002 commented on July 17, 2024

It does exists on production as well if we pinned enabled and grouped the link here is the screenshot in production
image

from biodrop.

Abhishek-90 avatar Abhishek-90 commented on July 17, 2024

@amandamartin-dev @sital002 I didn't check it on my phone but leaving the links section aside, even the buttons seem out of proportion for smaller screen sizes.

Coming to the links, we will have to come up with a different design on how to show the links data.

from biodrop.

sohail-313 avatar sohail-313 commented on July 17, 2024

Instead of text for "Pinned" and "Enabled" we will use Icons in mobile view, does it make sense?

from biodrop.

amandamartin-dev avatar amandamartin-dev commented on July 17, 2024

It does exists on production as well if we pinned enabled and grouped the link here is the screenshot in production image

Thank you for clarifying this is seen when there is a group. I was able to confirm. I saw you do not want to work on this but if you havre a suggestion on the best way to resolve feel free to offer a solution.

from biodrop.

amandamartin-dev avatar amandamartin-dev commented on July 17, 2024

Instead of text for "Pinned" and "Enabled" we will use Icons in mobile view, does it make sense?

Thank you for offering this idea. How will mobile users know what the icons each mean if we switch to icons?

from biodrop.

amandamartin-dev avatar amandamartin-dev commented on July 17, 2024

@amandamartin-dev @sital002 I didn't check it on my phone but leaving the links section aside, even the buttons seem out of proportion for smaller screen sizes.

Coming to the links, we will have to come up with a different design on how to show the links data.

Do you have a suggestion for improving this area?

from biodrop.

sohail-313 avatar sohail-313 commented on July 17, 2024

It does exists on production as well if we pinned enabled and grouped the link here is the screenshot in production image

Otherwise, we can do like this
image

from biodrop.

amandamartin-dev avatar amandamartin-dev commented on July 17, 2024

It does exists on production as well if we pinned enabled and grouped the link here is the screenshot in production image

Otherwise, we can do like this image

Oh I like the idea of stacking the tags underneath! I would like some other folks to weigh in though on the design change. WDYT @eddiejaoude ?

from biodrop.

sohail-313 avatar sohail-313 commented on July 17, 2024

Glad you liked it! Please assign me if approved

from biodrop.

eddiejaoude avatar eddiejaoude commented on July 17, 2024

yep stacking underneath seems like a good solution 👍

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

from biodrop.

github-actions avatar github-actions commented on July 17, 2024

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

from biodrop.

sohail-313 avatar sohail-313 commented on July 17, 2024

I am unable login because of missing "client_id"

screenshot of error

image

from biodrop.

Abhishek-90 avatar Abhishek-90 commented on July 17, 2024

@amandamartin-dev @sital002 I didn't check it on my phone but leaving the links section aside, even the buttons seem out of proportion for smaller screen sizes.
Coming to the links, we will have to come up with a different design on how to show the links data.

Do you have a suggestion for improving this area?

@amandamartin-dev I would suggest doing few things.

  1. Adding some space between different elements. It will give clear design for smaller screens.
  2. To address to the buttons issue above, we could use fluid design techniques to makes the buttons fluid depending upon the width of the screen/device.

from biodrop.

sid10on10 avatar sid10on10 commented on July 17, 2024

This issue was assigned one month back and is not yet closed. I want to work on this issue can you assign this to me? @eddiejaoude

from biodrop.

SaraJaoude avatar SaraJaoude commented on July 17, 2024

This issue was assigned one month back and is not yet closed. I want to work on this issue can you assign this to me? eddiejaoude

@sid10on10 as you will be able to see from the PR the assignee and the maintainers are still working on this so at this time we will not be assigning this issue to anyone else. Please also do not tag specific maintainers - all maintainers receive notifications and can deal with these. I suggest you take a look at this project's Contributing Guide, to familiarise yourself as to how this project is run.

from biodrop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.