Problem with Title-loc-args about pushok

[edamov]

Hi @eiosca.

Thanks for issue. I think it's the bug in the library, because the official documentation says the request should be like this:

{
    "aps" : {
        "alert" : {
            "loc-key" : "GAME_PLAY_REQUEST_FORMAT",
            "loc-args" : [ "Jenna", "Frank"]
        }
    }
}

[edwardmp]

@edamov
Thanks for making this! This bug seems to be solvable by just changing the key constants for loc-key and loc-args in Alert.php, right? If so just respond and I'll file a pull request.

[edamov]

The first problem is about naming: loc-key should be instead of title-loc-key. The same with loc-args.
And the second problem is about value of loc-args: it should be [ "Jenna", "Frank"] instead of {"0":"Jenna", "1":"Frank"}

[edwardmp]

Thanks, that's what I meant. PR submitted for first problem.

Second problem, is this really still there as there are already tests in AlertTest.php that confirm the expected behavior is present?

[nickasd]

This issue has not been completely solved, I still get this problem mentioned by @edamov:

And the second problem is about value of loc-args: it should be [ "Jenna", "Frank"] instead of {"0":"Jenna", "1":"Frank"}

I could solve it by removing JSON_FORCE_OBJECT from the argument list in Payload.php on line 278, but I'm not sure if this will break something else. Could you please have a look at this?