Comments (6)
I don't think [ 'wei', 'male', [ 15211111111, 13511111111 ], [ 'IBM', 'BJ' ] ]
is consistent with Laravel.
For example (in Laravel 5.4):
$collect = collect([
'name' => 'wei',
'sex' => 'male',
'phone' => [15211111111, 13511111111],
'company' => ['name' => 'IBM', 'city' => 'BJ']
]);
return dd($collect->toArray());
from collect.js.
It's not consistent with Laravel right now because in PHP have associative arrays, while JS don't.
I think it would be weird to return an object from a method called toArray()
, but it would be consistent with Laravel.
What do you think? I'm open for a discussion
from collect.js.
It is my (random JS developer) opinion that the closest equivalent data structure in JS would be a nested array of [key, value]
pairs. This is admittedly more awkward to work with than an object or real associative array. I wonder what the use case is for calling toArray()
on an object wrapped in collect
.
Input:
people = {
name: 'wei',
sex: 'male',
phone: [15211111111, 13511111111],
company: {
name: 'IBM',
city: 'BJ'
}
}
Output:
[
['name', 'wei'],
['sex', 'male'],
['phone', [15211111111, 13511111111]],
['company', { name: 'IBM', city: 'BJ' }]
]
from collect.js.
dont see the usefulness of this method, would you like to give a real use scenario of it?
from collect.js.
In my opinion calling it ToArray is not useful, unless you needed an array, that says pass it to method which only accepted Integer() as a parameter.
from collect.js.
Sorry for that I'm not familiar with Laravel, I propose this problem standing at the general position.
from collect.js.
Related Issues (20)
- Implement `chunckWhile`
- Implement `sortByMany`
- Implement `sortKeysUsing`
- Implement `add` HOT 1
- `first` passes a `null` argument to the function if the items inside the collection are organized in an object HOT 2
- [Feature request] optional() helper would be great HOT 1
- Does not work on AsyncGenerator HOT 1
- Pluck on Nested Arrays Help HOT 3
- Implement `undot`
- Support esm? HOT 8
- mapWithKeys().all() returns type array, when it's actually an object HOT 2
- Invalid `search` results HOT 1
- collect("").isEmpty()) return false. HOT 1
- Method `reduce` with `key/index` HOT 3
- `groupBy` on Object: `TypeError: this.items.forEach is not a function` HOT 1
- Wrong typescript definition for "when" method HOT 3
- Question: How do I perform a collection of where clauses with "or"? HOT 1
- Question: How to return an array of objects with only particular keys? HOT 1
- Bignum dependency crashing NPM when installing HOT 1
- Collapse Error: `Invalid attempt to spread non-iterable instance.`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collect.js.