Pool improvements about vertx-sql-client

[pratikpparikh]

@vietj can this be made part of 0.9.1 as this is very important to make sure that connection timeout is handled properly.

[vietj]

we will have this when we reuse the current pool implement from vertx

[vietj]

I'm scheduling this for 4.0

[vietj]

and for connect timeout there are chances it works correctly although one should check

[Globegitter]

@vietj what is the status on this? I can see one can already set a idleTimeout through PgConnectOptions, is that then also respected by the pool? But as far as I can see a connection timeout itself is still missing. Can you also confirm that?

Also is connectTimeout on PgConnectOptions respected by the pool?

And I agree with @pratikpparikh having a connection timeout would be important to have.

[Globegitter]

@vietj that is great news, but if now I set:

PgPool.pool(
        pgConnectOptionsOf(
            host = "localhost",
            port = 5432,
            database = "postgres",
            user = "postgres",
            password = "postgres",
            connectTimeout = 1000,
            idleTimeout = 1000,
            idleTimeoutUnit = TimeUnit.MILLISECONDS
        ),
        poolOptionsOf()
    )

then currently (v3.8.5) connectTimeout and idleTimeout is ignored by the pool?

[vietj]

those are connection settings, not pool settings. Those should have effect though, i.e the connection should be closed after 1s of TCP inactivity whehter it's int he pool or not.

[Globegitter]

Cool thanks for the quick responses, will give it a try and report back here.