Coder Social home page Coder Social logo

Comments (12)

merks avatar merks commented on July 29, 2024 3

It's great to get such timely feedback and then to get such timely fixes! ❤️

from eclipse.platform.ui.

ptziegler avatar ptziegler commented on July 29, 2024 1

Trying to run the task manually also behaves as expected 👍

image

from eclipse.platform.ui.

ptziegler avatar ptziegler commented on July 29, 2024

The Eclipse processes the content of Get-MpComputerStatus. This command already doesn't work. Reason being that the process isn't running in the first place.
image

My suggestion would be to first check wherer WindowsDefender is running and only then try to load its status.

from eclipse.platform.ui.

vogella avatar vogella commented on July 29, 2024

cc @HannesWell

from eclipse.platform.ui.

HannesWell avatar HannesWell commented on July 29, 2024

Thank you @ptziegler for the report and @vogella for linking me.

The Eclipse processes the content of Get-MpComputerStatus. This command already doesn't work. Reason being that the process isn't running in the first place.

That's interesting. I wasn't aware of that. Even when I had another AV-software installed this was working for me.

Based on your suggestion I'll add an invocation of (Get-Service 'WinDefend').Status as very first check and assume that win-defender is inactive if that doesn't return runningor fails (who knows what else can go wrong).

I'll create a PR later this evening and will submit it on time for tonight's I-build.

from eclipse.platform.ui.

ptziegler avatar ptziegler commented on July 29, 2024

That's interesting. I wasn't aware of that. Even when I had another AV-software installed this was working for me.

To be honest, I'm not 100% sure whether those errors are related and only something I found while looking for possible reasons for the error message of Get-MpComputerStatus:

https://techcommunity.microsoft.com/t5/windows-powershell/powershell-get-mpcomputerstatus/m-p/305684

More specifically:

However, if you have another anti-malware product installed e.g. McAfee, Norton, etc., these may/will disable Windows Defender and prevent the service from starting.

Which I believe to be the case. One could probably try to temporarily disable Windows Defender via Stop-Service windefend and then see how Get-MpComputerStatus behaves but I don't really have a Windows installation where I could easily do that... :/

from eclipse.platform.ui.

ptziegler avatar ptziegler commented on July 29, 2024

It might even be that Get-MpComputerStatus is simply not implemented for Cortex.
In any case, checking the status of Windows Defender should still be the way to go.

from eclipse.platform.ui.

HannesWell avatar HannesWell commented on July 29, 2024

However, if you have another anti-malware product installed e.g. McAfee, Norton, etc., these may/will disable Windows Defender and prevent the service from starting.

Which I believe to be the case. One could probably try to temporarily disable Windows Defender via Stop-Service windefend and then see how Get-MpComputerStatus behaves but I don't really have a Windows installation where I could easily do that... :/

I tried that on my personal Windows Computer where I actually have all permission and not even in a powershell started with admin privileges this call succeeds:

C:\Windows\system32> Stop-Service 'WinDefend'
In Zeile:1 Zeichen:1
+ Stop-Service 'WinDefend'
+ ~~~~~~~~~~~~~~~~~~~~~~~~
Das Skript enthält schädliche Daten und wurde von Ihrer Antivirensoftware blockiert.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : ScriptContainedMaliciousContent

In any case, checking the status of Windows Defender should still be the way to go.

I think that as well. Will continue with that approach.

from eclipse.platform.ui.

HannesWell avatar HannesWell commented on July 29, 2024

I tried out a little bit more, but didn't find a better solution and just created #1701.

from eclipse.platform.ui.

ptziegler avatar ptziegler commented on July 29, 2024

I just installed the I20240219-1800 and neither is the dialog shown, nor does any exception show up in the error log.
@HannesWell Thanks for the quick fix!

from eclipse.platform.ui.

HannesWell avatar HannesWell commented on July 29, 2024

I just installed the I20240219-1800 and neither is the dialog shown, nor does any exception show up in the error log. @HannesWell Thanks for the quick fix!

Great! Thanks for the fast feedback.

from eclipse.platform.ui.

HannesWell avatar HannesWell commented on July 29, 2024

I just want to take this issue as a good example to emphasize the importance of early testing the I-builds.
Not only will it reduce the probability of bugs in the final releases, one also gets fixes quicker since it is often just one nightly I-build away in contrast to three months or four weeks (if one only uses releases or milestone).
And last but not least it also makes it easier to identify the source of bugs if done regularly and it is easier to fix if the person who introduced it worked on the topic only a few days ago instead of maybe even months.

So thanks again for your early testing. :)

from eclipse.platform.ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.