ChooseWorkspaceDialog resolved path issues about eclipse.platform.ui

[laeubi]

@jukzi what happens if you try to press OK here...?
@HeikoKlare I think invalid path should result in the launch button to be disabled as well.

[HeikoKlare]

This is related to the behavior described in #1492 (comment) as it has the same reason.

The InvalidPathException thrown here needs to be handled:

eclipse.platform.ui/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java

Line 466 in f0cb362

Path path = location.getAbsoluteFile().toPath();

[jukzi]

eclipse starts with error:

[jukzi]

and it can not recover-- i am stuck in

after another restart :-(

[jukzi]

!SESSION 2024-01-19 10:15:03.620 -----------------------------------------------
eclipse.buildId=4.31.0.I20240118-1800
java.version=21.0.1
java.vendor=Eclipse Adoptium
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=de_DE
Command-line arguments:  -os win32 -ws win32 -arch x86_64

!ENTRY org.eclipse.emf.ecore 2 0 2024-01-19 10:15:05.861
!MESSAGE Both 'org.eclipse.cbi.p2repo.p2.maven' and 'org.eclipse.m2e.model.edit' register a package for 'http://maven.apache.org/POM/4.0.0'

!ENTRY org.eclipse.osgi 4 0 2024-01-19 10:15:06.501
!MESSAGE Application error
!STACK 1
java.nio.file.InvalidPathException: Illegal char <*> at index 50: C:\Users\jkubitz\platform-2024-01-10\eclipse\hello*
	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
	at java.base/java.io.File.toPath(File.java:2401)
	at org.eclipse.ui.internal.ide.ChooseWorkspaceDialog.getUnexpectedPathHint(ChooseWorkspaceDialog.java:466)
	at org.eclipse.ui.internal.ide.ChooseWorkspaceDialog.lambda$10(ChooseWorkspaceDialog.java:444)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:183)
	at org.eclipse.ui.internal.ide.ChooseWorkspaceDialog.createWorkspaceBrowseRow(ChooseWorkspaceDialog.java:458)
	at org.eclipse.ui.internal.ide.ChooseWorkspaceDialog.createDialogArea(ChooseWorkspaceDialog.java:195)
	at org.eclipse.jface.dialogs.TitleAreaDialog.createContents(TitleAreaDialog.java:166)
	at org.eclipse.jface.window.Window.create(Window.java:431)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1092)
	at org.eclipse.jface.window.Window.open(Window.java:788)
	at org.eclipse.ui.internal.ide.ChooseWorkspaceDialog.prompt(ChooseWorkspaceDialog.java:138)
	at org.eclipse.ui.internal.ide.application.IDEApplication.showChooseWorkspaceDialog(IDEApplication.java:440)
	at org.eclipse.ui.internal.ide.application.IDEApplication.promptForWorkspace(IDEApplication.java:371)
	at org.eclipse.ui.internal.ide.application.IDEApplication.checkInstanceLocation(IDEApplication.java:285)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:142)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:143)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:439)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:271)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:651)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:588)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1459)

[HeikoKlare]

You have to manually correct the preferences in configuration/.settings/org.eclipse.ui.ide.prefs until the bug is fixed
See #1492 (comment)

[jukzi]

thanks

[merks]

I guess -data would still work too.