Add "Generic Text Editor" strategy to the list of possible strategies about eclipse.platform.ui

[iloveeclipse]

OK, this will be it for now:

[laeubi]

Maybe even as simple as "Advanced Text Editor" ...

[akurtakov]

I honestly can't see why would someone prefer "Text Editor" over "Generic Text Editor" . It's pretty good to have the option but IMHO we should consider even removing Text Editor from this combo.

[laeubi]

I honestly can't see why would someone prefer "Text Editor" over "Generic Text Editor" . It's pretty good to have the option but IMHO we should consider even removing Text Editor from this combo.

I agree with @akurtakov that one simply should use generic editor (what IS a text editor anyways) I think a normal user can't really decide what is the difference between a Text and a Generic Editor (is a text editor not generic?), beside that the actual "generic" Editor is an Extensible (!) Text editor...

[iloveeclipse]

but IMHO we should consider even removing Text Editor from this combo.

The extra option in the combo doesn't harm, and if someone set this as default in the preferences, it will be most likely broken (haven't checked yet what happens if user choice is gone from the list).

But don't think this decision (remove or not default "Text" option) is blocking this enhancement request, one can work on that in parallel.

[laeubi]

But don't think this decision (remove or not default "Text" option) is blocking this enhancement request, one can work on that in parallel.

I think the suggestion is to simply not add new options but let the existing one use GenericEditor instead, so no UI change no preference change but better user experience.

[iloveeclipse]

I'm not sure about removal of something that was long time default.
Also there might be RCP's that don't include generic editor at all in the target platform.

[laeubi]

Also there might be RCP's that don't include generic editor at all in the target platform.

How does the new option then work? (just see it in the PR) If its just an ID, maybe one can try generic editor first and then that second...

[iloveeclipse]

maybe one can try generic editor first and then that second...

Once again: for the sake of compatibility with billions of existing workspaces & users in the world I prefer NOT to change behavior of the currently defined strategy, only to add new one.

Once it is considered useful & shows no unexpected side effects, we might discuss how the old one could be removed/migrated to the new one.

[laeubi]

But then please choose another name, "Generic Editor" is only something eclipse platform committers will understand and even they do not all might know what a "Generic Text Editor" versus a "Text Editor" is ...

[laeubi]

Maybe "Content Type Aware Text Editor" or similar even though I find it a bit lengthy @mickaelistria do you have an idea?

Maybe even if it is only different in context of TM4E one better contribute it there as a "TM4E Editor" ....

[iloveeclipse]

Maybe even if it is only different in context of TM4E one better contribute it there as a "TM4E Editor" ....

TM4E can contribute whatever strategy they want & use whatever name they want. SDK doesn't contain TM4E so we can't suggest here this name, especially the contribution here is only indirectly targeting TM4E but can be also used without it with something else like "TM42E++".

But then please choose another name, "Generic Editor"

Come on, lot of naming discussions were there while "Generic Editor" was chosen and "Generic" won the battle. Let don't start it again please.

[iloveeclipse]

Maybe even as simple as "Advanced Text Editor" ...

So should I change it now to "Advanced Text Editor" or not? But please no other naming proposals.

[laeubi]

Maybe even as simple as "Advanced Text Editor" ...

So should I change it now to "Advanced Text Editor" or not? But please no other naming proposals.

If you don't mind I would be thankful for that but you are Project Lead so final decision is on you :-)

[akurtakov]

Maybe even as simple as "Advanced Text Editor" ...

So should I change it now to "Advanced Text Editor" or not? But please no other naming proposals.

Please do. It's better information IMO.

[mickaelistria]

I submitted #1385 about finding a more explict name for the editor