Including timestamped send option to SendService about leshan

[sbernard31]

Iam not sure but maybeManualDataSender is what need ?

Do you test the it ? it is able to collect timestamped data then send all collected data ?

You can test its behavior with leshan-client-demo ? using this interactive command

help collect

Usage:  collect [<paths>...]
Collect data to send it later with 'send' command
      [<paths>...]   Paths of data to collect.

help send

Usage:  send [-c=<contentFormat>] (current-value | collected-value)
Send data to server
  -c, --content-format=<contentFormat>
         Name (e.g. SENML_JSON) or code (e.g. 110) of Content Format used to
           send data.
         Default : SENML_CBOR
Commands:
  current-value    Send current value
  collected-value  Send values collected with 'collect' command

You could have code example here :

leshan/leshan-client-demo/src/main/java/org/eclipse/leshan/client/demo/cli/interactive/InteractiveCommands.java

Lines 337 to 357 in f23254c

	/**
	* A command to collect data.
	*/
	@Command(name = "collect",
	description = "Collect data to send it later with 'send' command",
	headerHeading = "%n",
	footer = "")
	static class CollectCommand implements Runnable {
	@Parameters(description = "Paths of data to collect.", converter = LwM2mPathConverter.class)
	private List<LwM2mPath> paths;
	@ParentCommand
	InteractiveCommands parent;
	@Override
	public void run() {
	parent.client.getSendService().getDataSender(ManualDataSender.DEFAULT_NAME, ManualDataSender.class)
	.collectData(paths);
	}
	}

and

leshan/leshan-client-demo/src/main/java/org/eclipse/leshan/client/demo/cli/interactive/InteractiveCommands.java

Lines 307 to 335 in f23254c

	@Command(name = "collected-value",
	description = "Send values collected with 'collect' command",
	headerHeading = "%n",
	footer = "")
	static class SendCollectedValue implements Runnable {
	@ParentCommand
	SendCommand sendCommand;
	@Override
	public void run() {
	// get registered servers
	Map<String, LwM2mServer> registeredServers = sendCommand.parent.client.getRegisteredServers();
	if (registeredServers.isEmpty()) {
	sendCommand.parent.printf("There is no registered server to send to.%n").flush();
	}
	// for each server send data
	for (final LwM2mServer server : registeredServers.values()) {
	LOG.info("Sending Collected data to {} using {}.", server, sendCommand.contentFormat);
	// send collected data
	SendService sendService = sendCommand.parent.client.getSendService();
	try {
	sendService.getDataSender(ManualDataSender.DEFAULT_NAME, ManualDataSender.class)
	.sendCollectedData(server, sendCommand.contentFormat, sendCommand.timeout, false);
	} catch (NoDataException e) {
	sendCommand.parent.printf("No data collected, use `collect` command before.%n").flush();
	}
	}
	}
	}

If this doesn't match you need, could you try to explain why ? 🙏

[sbernard31]

Does that work for you ? should we close this issue ?

[Ozame]

Yes, this actually looks to be exactly what we needed, thank you! I will close the issue.