LoginContextDriver.doPasswordLogin() looses the thrown stack from a custom login module about glassfish

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/32
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @yaminikb
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented
danbrice said:
I just noticed that com.sun.enterprise.security.LoginException and not
javax.security.auth.login.LoginException which
com.sun.appserv.security.AppservPasswordLoginModule.login() throws.

A bit confusing given that the custom login module has to throw the javax version. Maybe there's
nothing can be done about that - but it would have been easier to code against if
com.sun.appserv.security.ProgrammaticLogin.login() threw specific exceptions instead of the all general
"Exception". Surely that could be changed without breaking any existing code.

Thanks,
Dan.

[glassfishrobot]

@glassfishrobot Commented
sridatta said:
changing owner to sridatta

[glassfishrobot]

@glassfishrobot Commented
@shingwaichan said:
reassigned to an engineer

[glassfishrobot]

@glassfishrobot Commented
ahshishs said:
Will make the change so that the root stack trace does not get lost.
I'll also file a bug to clean the following:
1. Some methods in ProgrammaticLogin public API throw java.lang.Exception
The exception should be changed to more narrow and specific subclass
2. LoginContextDriver methods throw com.sun.enterprise.security.LoginException
See if this can be changed to javax.security.auth.login.LoginException
3. com.sun.enterprise.security.LoginException extends java.lang.RuntimeException
(via java.lang.SecurityException) - which means this exception can go uncaught
at compile-time. Should be changed so the goes through the compiler checks.

[glassfishrobot]

@glassfishrobot Commented
ahshishs said:
Made the suggested changes througout LoginContextDriver so that the root cause
exception is not lost when creating a new LoginException.

[glassfishrobot]

@glassfishrobot Commented
Was assigned to ahshishs

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA GLASSFISH-32

[glassfishrobot]

@glassfishrobot Commented
Reported by danbrice

[glassfishrobot]

@glassfishrobot Commented
Marked as fixed on Tuesday, March 14th 2006, 6:25:56 am