Coder Social home page Coder Social logo

Comments (3)

bhufmann avatar bhufmann commented on August 30, 2024

While updating the CDT Cloud blueprint to the latest version of this extension i noticed that some dependencies do not seem to be provided correctly.

To be more specific: It seems like these dependencies from the root package.json are only references as dependencies there, but not in the theia-traceviewer extensions package.json.

Therefore, i need to manually add these dependencies to my project, when i want to consume the theia-traceviewer extension.

These dependencies should probably be added as peer dependencies in the theia-traceviewer package.json. Or was there a specifiic reason for it to be implemented this way?

No, I don't think there was a specific reason for that. When the change was introduced I think it was not noticed or not questioned. If you think that's incorrect, could you please provide a PR and we will review it.

Thanks for bringing this up.

from theia-trace-extension.

marcdumais-work avatar marcdumais-work commented on August 30, 2024

I believe that this is a legit issue - the way these production dependencies are defined ATM, they will be available to the test application but not be included in the published Theia extension. If they are only needed in the extension, I think they should be moved there.

from theia-trace-extension.

marcdumais-work avatar marcdumais-work commented on August 30, 2024

The two related @types dependencies [1] should probably be moved to the extension too, in devDependencies.

[1]

"@types/react": "^18.0.15",
"@types/react-dom": "^18.0.6"

from theia-trace-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.