Comments (3)
While updating the CDT Cloud blueprint to the latest version of this extension i noticed that some dependencies do not seem to be provided correctly.
To be more specific: It seems like these dependencies from the root package.json are only references as dependencies there, but not in the
theia-traceviewer
extensionspackage.json
.Therefore, i need to manually add these dependencies to my project, when i want to consume the
theia-traceviewer
extension.These dependencies should probably be added as peer dependencies in the
theia-traceviewer package.json
. Or was there a specifiic reason for it to be implemented this way?
No, I don't think there was a specific reason for that. When the change was introduced I think it was not noticed or not questioned. If you think that's incorrect, could you please provide a PR and we will review it.
Thanks for bringing this up.
from theia-trace-extension.
I believe that this is a legit issue - the way these production dependencies are defined ATM, they will be available to the test application but not be included in the published Theia extension. If they are only needed in the extension, I think they should be moved there.
from theia-trace-extension.
The two related @types
dependencies [1] should probably be moved to the extension too, in devDependencies
.
[1]
theia-trace-extension/package.json
Lines 131 to 132 in a1d5a0c
from theia-trace-extension.
Related Issues (20)
- TimeSelection Widget: It's impossible to have an empty text box for "pasting in" a good timestamp (from excel)
- Trace server does not use trace selection signals HOT 1
- Replace very old built-ins by builtins extensions pack
- Use Theia's re-exports in example app instead of direct imports HOT 1
- Update "@theia" packages (extensions) list, to include interesting recent extensions
- Update to recent version of lerna dependency
- Update to Node 18
- Histogram view for experiments with 2 traces with same name and different directory not working well
- Events Table trace column for experiments with 2 traces with same name and different directory confusing
- Thread status and resources view show only one trace for experiments with multiple kernel traces with same name
- Dispose experiment/trace back-end resources when closing an experiment from the UI
- Add units for time and duration in tooltips
- Perform automated 3PP license check as part of CI for PRs
- Handle opening of single trace files via dialog HOT 2
- Add filter Thread Status HOT 10
- webpack.config.js missing in docker example HOT 1
- Make example applications more like trace viewer appliances
- Selection of row in segment store table (e.g. IRQ Latency Table) doesn't select time in other views HOT 1
- Add additional filter on Event Table HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theia-trace-extension.