Coder Social home page Coder Social logo

Suggest to remove obsolete (?) package org.eclipse.basyx.vab.protocol.opcua.server and dependency to Milo "sdk-server" about basyx-java-sdk HOT 4 CLOSED

eclipse-basyx avatar eclipse-basyx commented on June 30, 2024
Suggest to remove obsolete (?) package org.eclipse.basyx.vab.protocol.opcua.server and dependency to Milo "sdk-server"

from basyx-java-sdk.

Comments (4)

in-fke avatar in-fke commented on June 30, 2024

Dependency Footprint of Milo "sdk-server" (though, some are overlapping with "sdk-client")

[INFO] +- org.eclipse.milo:sdk-server:jar:0.6.8:compile
[INFO] |  +- org.eclipse.milo:stack-core:jar:0.6.8:compile
[INFO] |  |  +- org.bouncycastle:bcprov-jdk15on:jar:1.69:compile
[INFO] |  |  +- org.bouncycastle:bcpkix-jdk15on:jar:1.69:compile
[INFO] |  |  |  \- org.bouncycastle:bcutil-jdk15on:jar:1.69:compile
[INFO] |  |  \- org.glassfish.jaxb:jaxb-runtime:jar:2.3.6:compile
[INFO] |  |     +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
[INFO] |  |     +- org.glassfish.jaxb:txw2:jar:2.3.6:compile
[INFO] |  |     +- com.sun.istack:istack-commons-runtime:jar:3.0.12:compile
[INFO] |  |     \- com.sun.activation:jakarta.activation:jar:1.2.2:compile
[INFO] |  +- org.eclipse.milo:stack-server:jar:0.6.8:compile
[INFO] |  \- org.eclipse.milo:bsd-generator:jar:0.6.8:compile
[INFO] |     \- org.eclipse.milo:bsd-core:jar:0.6.8:compile

from basyx-java-sdk.

FrankSchnicke avatar FrankSchnicke commented on June 30, 2024

Thanks for pointing this out. However, removing this package would result in a breaking change for users who are utilizing the opcua integration of the VAB - e.g., the developers at Papyrus4Manufacturing. Thus, removing this package is not possible

from basyx-java-sdk.

in-fke avatar in-fke commented on June 30, 2024

Well I guess 0.x version would tend to have breaking changes (that need to be announced) - and the class KeyStoreLoaderClient is already marked deprecated. It's nothing you need to rush - just something I noted when looking at all the transitive dependencies. If Papyrus4Manufacturing would depend on milo-server, it could include it as a direct dependency.
If Papyrus4Manufacturing would "just" depend on KeyStoreLoaderClient they might as well "copy" it to their project?

If both are NOT depending on milo-server, - or just on HostnameUtil class in milo-server. You might as well copy the source code of org.eclipse.milo.opcua.sdk.server.util.HostnameUtil for the use in KeyStoreLoaderClient to basyx.sdk, thus effectively removing the dependency to milo-server, just because of this single class HostnameUtil.

from basyx-java-sdk.

FrankSchnicke avatar FrankSchnicke commented on June 30, 2024

These are good ideas, however, they will also result most likely in breaking changes for our users. Thus, similar to #268, we won't address this anymore in BaSyx Java V1.X

from basyx-java-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.