Coder Social home page Coder Social logo

Comments (8)

twebermartins avatar twebermartins commented on August 17, 2024

Thanks @bs-jokri for raising this. We will have a look at it.

from aas4j.

FrankSchnicke avatar FrankSchnicke commented on August 17, 2024

I'm not sure if this is a bug related to AAS4J. In the schema location, pairs of namespaces as well as their respective schema location are provided. Thus, xsi:schemaLocation="https://admin-shell.io/aas/3/0/AAS.xsd" does not make much sense due to the file itself missing (i.e., the second entry in the schemaLocation tag). Nevertheless, it would make more sense to replace AAS.xsd with https://github.com/admin-shell-io/aas-specs/blob/V3.0.7/schemas/xml/AAS.xsd

Can you provide an error log of the AASX Package Explorer of an unsuccessful load?

from aas4j.

sebbader-sap avatar sebbader-sap commented on August 17, 2024

I was not able to reproduce the described behaviour with AASX Package Explorer v2023-09-12.

However, what I did find out:

  1. This minimal example can be loaded by the Package Explorer:
<?xml version='1.0' encoding='UTF-8'?>
<aas:environment xmlns:aas="https://admin-shell.io/aas/3/0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="https://admin-shell.io/aas/3/0 AAS.xsd">
  <aas:assetAdministrationShells>
    <aas:assetAdministrationShell>
      <aas:id>AssetAdministrationShell---2CEBD072</aas:id>
      <aas:assetInformation>
        <aas:assetKind>Instance</aas:assetKind>
      </aas:assetInformation>
    </aas:assetAdministrationShell>
  </aas:assetAdministrationShells>
  <aas:submodels />
  <aas:conceptDescriptions />
</aas:environment>
  1. AAS4J serialises this here (note the missing aas:submodels and aas:conceptDescriptions), which leads to an error:
<?xml version='1.0' encoding='UTF-8'?>
<aas:environment xmlns:aas="https://admin-shell.io/aas/3/0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="https://admin-shell.io/aas/3/0 AAS.xsd">
  <aas:assetAdministrationShells>
    <aas:assetAdministrationShell>
      <aas:id>AssetAdministrationShell---2CEBD072</aas:id>
      <aas:assetInformation>
        <aas:assetKind>Instance</aas:assetKind>
      </aas:assetInformation>
    </aas:assetAdministrationShell>
  </aas:assetAdministrationShells>
</aas:environment>

from aas4j.

sebbader-sap avatar sebbader-sap commented on August 17, 2024

As https://github.com/admin-shell-io/aas-specs/blob/2fe82a66ca502f9c5aea1ef0de0baaa729469faf/schemas/xml/AAS.xsd#L327 states that, e.g., submodels is optional but must not be empty, I see this as a bug in the Package Explorer.

from aas4j.

sebbader-sap avatar sebbader-sap commented on August 17, 2024

@FrankSchnicke can you follow my arguments? If so, can you add it to the bug you have already opened in the Package Explorer?

from aas4j.

sebbader-sap avatar sebbader-sap commented on August 17, 2024

(Remark: I had only a limited environment available for my tests, I was able to use v2023-09-12 but without needed .NET Core libraries - no permissions to install on my VM. Therefore, I am not 100% sure whether my Package Explorer behaves identical to others.)

from aas4j.

FrankSchnicke avatar FrankSchnicke commented on August 17, 2024

@sebbader-sap I added your findings to the ticket over at the AASX PE Repo: admin-shell-io/aasx-package-explorer#653.

@bs-jokri since @sebbader-sap could not reproduce the issue, I will close this ticket. For the general overview of compatibility issues related to bugs with AAS4J but also with AASX PE see #158

from aas4j.

bs-jokri avatar bs-jokri commented on August 17, 2024

@sebbader-sap @FrankSchnicke thanks to both of you looking into the issue. I also tested again and can second @sebbader-sap observations. My test model also missed some optional elements, which might caused the problem not the schemaLocation. Thus, fine with me closing the issue

from aas4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.