Coder Social home page Coder Social logo

Comments (6)

rbygrave avatar rbygrave commented on August 22, 2024

I agree with this as a BUG / ENHANCEMENT. I might adjust the title to reflect that this is a DDL generation issue.

Cheers, Rob.

from ebean.

rbygrave avatar rbygrave commented on August 22, 2024

Looking at this some more I think we can classify this as a BUG.

In terms of the solution ...

solution would be to add a configuration parameter to ebean - which validation group should be used for schema generation

Actually I think instead of this it could/should be that to generate the DDL Not Null constraint there needs to be no validation group defined or that 1 validation group is defined and it is assignable to javax.validation.groups.Default. If this is the case we can say that for every row the Not Null constraint can be applied (and hence we can DDL generate the Not Null constraint).

from ebean.

rbygrave avatar rbygrave commented on August 22, 2024

Pushed commit c176e4f ... into MASTER as the fix for this issue.

from ebean.

rbygrave avatar rbygrave commented on August 22, 2024

Let me know if you are happy enough with the fix and if so we'll close this issue.

Cheers, Rob.

from ebean.

rbygrave avatar rbygrave commented on August 22, 2024

Actually I'll just close this at this point - I'm pretty satisfied that we don't need the configuration support etc.

Let me know if you are looking for some adjustment to the commit that is now in master.

Cheers, Rob.

from ebean.

 avatar commented on August 22, 2024

Hi,

wow, thanks for fixing it that quickly!

This is perfect for me. I don't need any additional configuration parameters, just thought that it may come in handy in some use-cases. I'm happy with fixes provided by you.

Marcin

from ebean.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.