Purpose for print.report_table containing several package calls about report

[DominiqueMakowski]

Very good question!

I think that insight::format_table() is mainly a table formatted converting a dataframe to a table-like display when printed in the console (adding columns separators, spaces etc.). Whereas parameters_table is mainly a function that renames some columns for pretty printing, for instance if it detects the presence of columns named CI_low and CI_high, it will merge into one column named for instance 95% CI

PS: we are currently finishing a restructuration that has seen some parts of parameters and report going into the new effectsize package. Hence, it is likely that report will have to be restructured quite a bit in the days to come.

In particular, I am thinking about creating two main functions, model_table and model_text. The former would pull performance, parameters and effect size data and merge them together nicely (rmarkdown printing will probably have to be connected at this level), and model_text will transform this table to text. Then, the report function will mainly run these two subfunctions and return it all.

[DominiqueMakowski]

Closing as part of the house-cleaning related to the recent rewriting (so I can see clearer in the issues), but that's still an area of improvement.

Currently the printing of tables relies on insight and parameters:

report/R/report_table.R

Lines 100 to 102 in cbdd7f9

	print.report_table <- function(x, ...) {
	cat(insight::format_table(parameters::parameters_table(x, ...), ...))
	}