[Question]: New filter run panic about easegress

[cyrnicolase]

Thank you very much!

[suchen-sci]

copy that, i will try to find out what happens.

[suchen-sci]

func (e *Echo) Name() string {
	return e.spec.Name()
}

There is a bug when generate code. Name() method should return name of spec.

[cyrnicolase]

It works.

The error message is not clear. Is there any way i can clearly understand the cause of the error ?

[suchen-sci]

p.filters[filter.Name()] = filter

https://github.com/megaease/easegress/blob/main/pkg/object/pipeline/pipeline.go#L292

In flow, the filter name is echo. But in pipeline, the name became Echo. So when do handle, pipeline gets a nil. And a call Handle to nil causes the panic.

I will make a pr to fix the bug and also add some integration tests to make sure the kind of error never happen again!

[cyrnicolase]

Sorry , I reopen this issue. I still have a question . As I mentioned above, may I know more accurate error information, not like this:

I can know which filter , where is the bug.

[suchen-sci]

This is a little embarrassing for me.
Usually, Easegress prints error message when meet an error, used for users to debug. For example, for proxy filter, the backend is not exist, or an invalid spec.

In this case, this panic caused by a bug of egbuilder, I am afraid that we usually don't have error messages for a bug. Bug is not want we want, it always happens in an unexpected way. If we know there may be a bug, then we fix it before it cause a problem. So I actually do some diggings to find where cause the problem.

Here is what I do to find this bug, first I update the pipeline yaml, make it only contains one filter of proxy, then I find it works as expected. So, the bug happens in the new filter. Then I do some print in pipeline.go to find why I success to create it but fail to use it. Then I find the problem...

easegress-server expects filter.Name() return same value of spec.Name(). And it is true. The problem caused by egbuilder, it makes a mistake when generates the code.

[cyrnicolase]

thanks, I get it