Comments (10)
Memory leak appears to have been fixed- thanks for the quick patch!
from jelly-bean-world.
Thanks for the report! I'll look into this and see if I can find the memory leak.
I think your current workflow is fine for episodic experiments. JBW was designed specifically for the never-ending/continual setting so we didn't do much testing for episodic use-cases.
from jelly-bean-world.
That makes sense. This would be difficult to find in the continual setting, as as it's only 12MiB.
from jelly-bean-world.
I just pushed a commit that fixes one memory leak. It was a subtle bug where we were creating a cyclic reference where C++ would reference the callback functions in the Simulator object, and the callbacks and Simulator object reference each other. So the Simulator object would never be garbage collected, even if there were no references to it from Python.
You might need to force garbage collection after each episode if you want to make sure that memory usage stays constant, otherwise it seems to garbage collect every ~10 episodes in my tests.
from jelly-bean-world.
Let me know if this change fixes the issue in your setup.
from jelly-bean-world.
from jelly-bean-world.
Hi, I think with the updated simulator.py and simulator.cpp, the "jbw-v1" environment is not returning correct reward value. Can you please double check this?
from jelly-bean-world.
Oh weird. Thanks for letting me know. I'll look into it.
from jelly-bean-world.
@sophistz I found an bug that I had created in fixing the memory leak. 😅 I just pushed some changes that will hopefully fix it.
from jelly-bean-world.
@asaparov Thanks. The code works now!
from jelly-bean-world.
Related Issues (14)
- Testing the testbed HOT 2
- Building error (‘sim’ was not declared in this scope ...) HOT 2
- Agent vision does not update after step HOT 1
- Error when using jbw HOT 9
- Some questions HOT 11
- Rewards HOT 24
- Paper/code discrepancies and PR for case studies in Python HOT 2
- Adding an agent is very slow HOT 4
- Environment isn't modified after loading from filepath HOT 3
- Error when installing HOT 4
- [feature request] allowing user play / control HOT 1
- Slowing down when running multiple experiments HOT 1
- pip support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jelly-bean-world.