Coder Social home page Coder Social logo

Comments (7)

DZunke avatar DZunke commented on July 20, 2024 2

Hey,

thanks for your hint. I will have a look at it in a few days along with some other changes to create a v2 tag. Hopefully i will be able to deliver it at the end of the next week, at latest!

from slackbundle.

alister avatar alister commented on July 20, 2024 1

"dev-2.0-dev" has been running in prod on my site for a while now - admittedly, with very light traffic - but there's been no issues for me with the bundle/code. If you wanted to make a 2.0.0 release, I'd happily update my own composer.json for it.

from slackbundle.

DZunke avatar DZunke commented on July 20, 2024

Sorry for delay. I have created a new branch 2.0-dev to create some Non-BC changes. The Guzzle upgrade to v6 is already included and should work if you want to try it 😄

from slackbundle.

alister avatar alister commented on July 20, 2024

I've got it working (at least, it sends a message via bin/console dzunke:slack:message), however there were two issues:

  1. I was being caught by my home ISPs proxy page before it would redirect to the secure URL, but adding endpoint: "https://slack.com/api" to the config sorted that (making it the default in getConfigTreeBuilder() may be useful).

  2. In Slack\Client\Response::parseGuzzleResponse(): Just $guzzleResponse->getBody(true), returns a GuzzleHttp\Psr7\Stream, so ....

    // To return the contents of the response, decoded
    $responseArray = json_decode($guzzleResponse->getBody()->getContents(), true);

    // Also usefully, PHP 5.6+ allows for:
    use function GuzzleHttp\json_decode;
    // Wrapper for json_decode that throws when an error occurs.

Thanks for all your efforts.

from slackbundle.

alister avatar alister commented on July 20, 2024

I've made #16 with the two changes

from slackbundle.

DZunke avatar DZunke commented on July 20, 2024

Thanks for the MR. I think all is working now. My test.php is working. Missed that i'd used https and haven't added it to the defaults. Sorry!

from slackbundle.

DZunke avatar DZunke commented on July 20, 2024

Hey alister, sorry for late Response. Seems i have no time to run for some changes i had planed so i will prepare release 2.0 today. Thanks for your support 😺

from slackbundle.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.