Comments (5)
As mentioned in the pull request, if I understand this correctly, I think it would be better to expunge on the outside, where the object is created.
from jarvis.
I notice now that making a response includes expunging the object as a part of its work. This makes me wonder now whether it is even necessary to expunge the object when we return from HandleRequest
?
from jarvis.
I'm referring to this apparently excessive expunge:
Line 446 in ccd05ff
from jarvis.
d2c5e53 removes the extra expunge here, and now the only expunges are on the outside caller to HandleRequest
and inside of the Respond
function. Are they both necessary?
from jarvis.
Yeah, the duplicate expunge was a remnant of cope that was lifted from elsewhere. While it's harmless I'll address it.
from jarvis.
Related Issues (20)
- Allocate Port <1024 under *nix
- Break links to source files when building workspace HOT 1
- Not an issue HOT 3
- Add HTTP compression HOT 1
- Should URLDecode come after splitting the query parameters? HOT 1
- Add hook for custom HTTP failures
- Allow dynamic session creation
- RFE: _htmlDefaultPage should be a public field, ideally also configurable via jarvis.json HOT 1
- "ConfigFile" settings conflicts with name of Dyalog Settings HOT 3
- DYALOG_JARVIS_THREAD should default to "1" and not "DEBUG"
- AutoStart fails if AuthenticateFn has wrong valence, but does not show the info about the error.
- Sort out CodeLocation and JarvisConfig in relation to Jarvis.dws Autostart
- Consider making IncludeFns and ExcludeFns properties rather than fields HOT 1
- Web interface fails if exposed functions contain ∆
- Allow .apla (APL array) files to be loaded
- EndPoints needs to be ⎕ML/⎕IO insensitive
- Don't close connection for in-process request
- Add MaxPayloadSize setting
- Return 431 status when headers are too large HOT 1
- Any chance of supporting GZip, deflate please. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jarvis.