Comments (11)
Works well now. Thank you !
from ssl-checker.
Basically, you should rely on response.socket.authorized
which already contains result of validation
from ssl-checker.
@felicienfrancois are we talking about this case https://wrong.host.badssl.com/
from ssl-checker.
@dyaa Exactly.
Using response.socket.authorized
may also cover other cases of "invalid certificates"
from ssl-checker.
So, You expect if the response.socket.authorized
was false
to return an error instead of returning the remaining date? @felicienfrancois
from ssl-checker.
@dyaa yes because in this case the certificate is invalid.
from ssl-checker.
in this case the expired domain will fail as well, Currently we return the data object with negative days_remaining
.
from ssl-checker.
I suggest to add a field to returned payload so it won't makes any braking changes.
Example :
{
"valid" : true, // whether certificate pass ssl validation or not
"days_remaining" : 90,
"valid_from" : "issue date",
"valid_to" : "expiry date"
}
from ssl-checker.
Published a new version [email protected]
with these changes, Please Verify.
from ssl-checker.
@dyaa now I get an SyntaxError: Unexpected token import
at index.js:3
It seems that you changed require
to import
which is not supported natively on my node version (8.9.3).
from ssl-checker.
Done, Check [email protected]
from ssl-checker.
Related Issues (20)
- [Query] Can I check a crt file in local when it is expired? HOT 2
- validFrom, validTo, and validFor are valid but valid is false HOT 3
- May change the export of your library HOT 1
- Resolve domain to IP address behind DNS
- Specify Proxy for request
- daysRemaining is not accurate HOT 1
- Revoked certificate is flagged as valid HOT 1
- Update npm repository version
- Handling unknown or unreachable domains HOT 1
- How to use a proxy?
- getaddrinfo ENOTFOUND Error on paths without a resource point.
- Valid wildcard certificate is not passing the check
- Module has no default export HOT 5
- False negative in certain websites HOT 1
- TypeError: sslChecker is not a function HOT 3
- subjectaltname causing valid cert to fail HOT 4
- Create new release 2.0.10 HOT 2
- Remove Valid Host Check as it does not cover all Domains
- When i try to open a localhost site get error HOT 6
- Localhost get error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssl-checker.