Coder Social home page Coder Social logo

Comments (5)

brianjmurrell avatar brianjmurrell commented on July 25, 2024

Hrm. Battery aside, updating -- actually calling analogRead() I would guess -- on every loop iteration affects other things. For example, on an ESP8266, it causes the WiFi module to go non-responsive.

If I call .update() in every loop() cycle, my module only responds to ping for a few seconds after reboot and then stops. If I only call .update() once per second, this does not happen.

So, while I can surely add such a delay to all of my sketches, I think it needs to be reconsidered if this library really ought to be doing an analogRead() as frequently as every loop iteration or whether every user of this library needs to build delay into their sketches or whether this library should have some built in, user settable, sampling delay/rate.

from responsiveanalogread.

mikegleasonjr avatar mikegleasonjr commented on July 25, 2024

I guess it is you who decide when you call .update(). Examples are provided with an update in the loop but ultimately you choose.

from responsiveanalogread.

brianjmurrell avatar brianjmurrell commented on July 25, 2024

Of course, I, and everyone else could write .update() delays/sampling into their main loop()s.

Do you not think doing so right inside the library so that .update() can just be called on every loop iteration is a useful feature of the library? I can most certainly push a PR if you think it's useful enough to merge it.

from responsiveanalogread.

mikegleasonjr avatar mikegleasonjr commented on July 25, 2024

Not maintainer just a library user. But in my opinion it belongs in userland (deciding when to update).

from responsiveanalogread.

dxinteractive avatar dxinteractive commented on July 25, 2024

As mikegleasonjr said, the library is only called every loop if you call it every loop. It's deliberately up to you as a dev when to call update, because the frequency at which you call it will affect some of the parameters you'll use.

from responsiveanalogread.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.