Comments (9)
Amazingly this has never worked in the year since it was checked in! A resounding statement that untested projects are going to be big disappointments. Thankfully @yyuu did something about the tests and since the windows aren't so broken anymore I fixed and tested this in 73aba99 .
from sbt-extras.
I'd like to clarify a few more things about this bug report:
This situation will also happen when building on Travis CI...
No, the version of sbt-extras
(2fd0642) that currently runs on Travis CI is not (so) flawed as reported here. By default /etc/sbt/jvmopts
is successfully loaded (skipping the two comments and the blank line mentioned above), as illustrated by these examples:
- https://travis-ci.org/scalaz/scalaz/jobs/19503327#L17-L40
- https://travis-ci.org/twitter/scalding/jobs/19358087#L24-L42
For an example see this failed Travis CI build triggered by this script.
In mohiva/play-silhouette@bd17777, Travis script was customized to run with a more recent version of sbt-extras
(apparently b170cdd), which indeed is broken.
I didn't take time to identify the cause of the regression... But yeah, having automated tests/specs is the only way!
As still unexperienced shellscripter and moreover non-native english speaker, I am not certain to fully understand last part of 73aba99 commit comment:
, but lines with a non-initial # are options
@paulp Do you want to support non-initial # comments or not?
I ask because my original regexp-based implementation supported it...
PS: This is great that sbt-extras
is now checked by travis :)
from sbt-extras.
"I ask because my original regexp-based implementation supported it..."
Did it handle all the forms of quoting which might appear? The problem is if you want to pass a string containing a #, e.g. as part of a system property. Even if it did handle this - and it's really tricky with regexps - I find the feature unnecessary and prefer the implementation which doesn't take on baroque quoting issues.
from sbt-extras.
@gildegoma Indeed try your runner with a .jvmopts of
-Dfoo.bar="my #string"
and you will see what I mean.
from sbt-extras.
Sure, I understand :)
"I ask because my original regexp-based implementation supported it..."
You're right to correct me on this point. Sorry for writing this line too fast. I was not pretending my implementation was so robust, but I just wanted to be sure that we all agree to drop this feature.
And fixing this weakness is actually a good argument to update the sbt-extras
version on Travis CI as well. I'll take care of this...
from sbt-extras.
It wasn't exactly fixed until just now, but as of 4f44188 I believe it is.
from sbt-extras.
@paulp looks good! Thanks again for all your amazing work!
I'll keep you informed about the update on Travis CI.
from sbt-extras.
Thank you @paulp and @gildegoma for looking into this.
from sbt-extras.
FYI: the JVM worker machine on Travis CI (.org) will be updated in the next days with 60b6f26. The exact rollout date will be announced on http://blog.travis-ci.com.
Note that sbt 0.13.2 won't be pre-installed in this VM image, but in next VM update.
from sbt-extras.
Related Issues (20)
- Update script installation path in README HOT 1
- [Request] Automatically use `sbtn` launcher when possible HOT 2
- -XX:+UseJVMCICompiler option doesn't work with Apple Silicon Mac (M1) HOT 1
- Presence of .sbtopts makes SBT_OPTS ignored
- "Invalid formula" errors on install
- use GitHub Actions instead of Travis CI
- How to use this in Dockerfile? HOT 1
- Ignore CR (\r) when reading .jvmopts, for Windows
- Regression for -sbt-launch-repo option with private nexus HOT 2
- sbtx can't load 1.4.8 or 1.4.9 projects HOT 1
- sbtx --client always returns exitcode=0 HOT 8
- JVM version detection chokes on "17-ea", causing bad JVM option to be passed HOT 1
- Double dash options are incorrectly passed as commands
- "Cannot use JVMCI compiler: No JVMCI compiler found" error with JDK17 HOT 3
- script killed when run inside docker process HOT 1
- -XX:+UseJVMCICompiler with OpenJDK 11.0.14 causes build warnings HOT 5
- .jvmopts is parsed differently comparing to the original(*) sbt launcher HOT 1
- repo.typesafe.com down: Invalid or corrupt jarfile HOT 2
- Cannot set JVM flags via `SBT_OPTS`
- JVM version detection chokes on "17-internal"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-extras.