Coder Social home page Coder Social logo

Comments (7)

jedws avatar jedws commented on July 17, 2024

The associated PR appears to be sound. Any reason not to merge?

from sbt-extras.

jedws avatar jedws commented on July 17, 2024

even the brew installed bash doesn't include readarray, making it painful to set project specific jvmopts on MacOS

from sbt-extras.

gildegoma avatar gildegoma commented on July 17, 2024

I'm a bit concerned by this issue, because I also fall in that pit. In 3e34bce of PR #43, I actually propose to add a dependency check on bash version, and refuse to run with bash elder than version 4. Here are a few more inputs about this integration problem:

  • Indeed, Mac OS X 10.7 ships bash 3.2.48, released in 2007! (I did not check 10.8). Bash 4 (which introduced readarray built-in) came out in february 2009 already! Mmmh... Bash 3 is GPL v2, while Bash 4 is licensed under GPL v3. I let you compare philosophies between *BSD or Linux distributions, IBM AIX and 🍎 ... and make your opinion.
  • Hopefully homebrew provides bash 4.x for quite some time. Thanks homebrew to save OS X!
    • @jedws (even the brew installed bash doesn't include readarray...): I think you should have something wrong in your brew configuration... it works like a charm for me.

@paulp should decide if default portability (over "ages") or bash comfort should be privileged... I prefer the second way, which is more modern and elegant in my opinion!

from sbt-extras.

jedws avatar jedws commented on July 17, 2024

@gildegoma I couldn't get it working for some reason, but all I really wanted was to get enough memory for SBT and didn't spend a lot of time on it. At the moment I'm resorting to hacking the sbt-extras script to do so. Diagnosing the problem was the real time-sink.

from sbt-extras.

gildegoma avatar gildegoma commented on July 17, 2024

@jedws I perfectly understand your point. If this PR is not accepted, sbt-extras should check and claim "bash 4" requirement to avoid such annoying situation.

from sbt-extras.

gildegoma avatar gildegoma commented on July 17, 2024

PR #46 has been merged, this issue can be closed.

from sbt-extras.

paulp avatar paulp commented on July 17, 2024

For the record, the reason this situation can arise given that I am on OSX all the time is that I'm also using bash4 all the time. It's not my intention to require bash4, but neither is this project a high enough priority for me for me to do much beyond my own requirements. In any case I take it it's fixed, which is good.

from sbt-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.