CoreLocation attempts to match rules even if disabled about controlplane

[djbe]

Oh good one, never thought of that :-P
It does stop updating it (see stop method). Just add an if (!running) return NO at the start of doesRuleMatch

[dustinrue]

Not supposed to even get that far, CPController shouldn't even go asking it I don't think. Need to look into it more

On Oct 9, 2011, at 7:42 PM, David Jennes wrote:

Oh good one, never thought of that :-P
It does stop updating it (see stop method). Just add an if (!running) return NO at the start of doesRuleMatch

Reply to this email directly or view it on GitHub:
#57 (comment)

[dustinrue]

Fixed in 8f9d60d

[djbe]

Huh, so there was no internal check to see if the source was running.

But this is actually kind of bad behavior: sources should be enabled if there is a rule that needs it, not the other way around. Good news is that this doesn't happen in the rewrite :-D

[dustinrue]

Yea, my solution for this bit of a hack. Really CP is partially able to decide if an evidence source should be enabled but it'd take more work to get it working properly. I don't think the codebase currently allows for CP to gather data when an evidence source is disabled, but you can't create a rule of a certain type without the source enabled either, bit of a catch 22.

On Oct 9, 2011, at 9:17 PM, David Jennes wrote:

Huh, so there was no internal check to see if the source was running.

But this is actually kind of bad behavior: sources should be enabled if there is a rule that needs it, not the other way around. Good news is that this doesn't happen in the rewrite :-D

Reply to this email directly or view it on GitHub:
#57 (comment)